Fixed. The backlog of 20 was too large, meaning that the UI could never cancel requests quickly enough to actually be still in the queue because, each time we dropped back to the event loop, we'd fire another request. That turned all the cancel messages effectively into no-ops.
I also changed the rate limiter to use LIFO instead of FIFO. This gives a cancel message a much better chance of still finding a request waiting in the queue, so it can really be cancelled. This massively improves the user experience with a cold cache when scrolling through a large collection of songs because the requests that become visible once scrolling stops are dealt with first. (Previously, the thumbnails for songs visible at the end of the scroll would appear only once all preceding thumbnails (now no longer visible) had been dealt with.) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to thumbnailer in Ubuntu. https://bugs.launchpad.net/bugs/1531038 Title: Cancellation happens too late Status in thumbnailer package in Ubuntu: New Bug description: I'm still not happy with cancellation. The thumbnailer handles cancellation correctly, that is, successfully cancels anything that hasn't been sent via dbus yet. But it doesn't work well at the UI level. When thumbnailing a large collection of MP3s without artwork and scrolling forward quickly, the requests that are scrolling off the top of the screen are not physically cancelled, so it takes a long time for the thumbnails for the visible section of the list to show up. In addition, more often than not, the application times out and shows "no artwork" images. Ideally, I'd like to see whatever is in the currently visible section to get priority. Need to investigate what exactly is going on here and whether there might be a way to mitigate the issue. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/thumbnailer/+bug/1531038/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
