Actually, a browser change might not be needed. For non-overridable errors, the browser doesn't present any buttons in the error UI which means that the only way to dismiss the error is hit the back button. This still works correctly with my proposed changes, because CertificateError.cancelled fires.
If the browser presented a dismiss button in the error UI (which I thought it did when I suggested we might need a browser change), then the browser would need to ensure the CertificateError is deleted so that Oxide removes the placeholder transient page that gets inserted. That doesn't appear to be the case though. So far the browser is working fine with my changes -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to webbrowser-app in Ubuntu. https://bugs.launchpad.net/bugs/1504853 Title: Certificate errors in the browser are confusing Status in Oxide: In Progress Status in webbrowser-app package in Ubuntu: Confirmed Bug description: When the browser displays a certificate error, it indicates the request URL that the error originated from. This is fine. However, if the navigation is content initiated then the addressbar will indicate the URL of the currently committed page (which will be different to the URL of the page causing the error, which is displayed in the error UI provided by the browser). I have an idea to fix this by navigating the webview to a placeholder interstitial page whilst waiting for a response from the browser. This will update the addressbar, keep the navigation history consistent and also make the back button behave the same as Chrome. To manage notifications about this bug go to: https://bugs.launchpad.net/oxide/+bug/1504853/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
