On 06/01/13 12:06, Maksim Melnikau wrote: > 2. if program segfaults - it has a bug, always, there is now excuse > for it, programs shouldn't segfault on non-correct data
I agree: the usual Telepathy rule is "don't be crashable by someone on the other side of D-Bus, even if they're wrong". I've applied the patch, with minor (non-functional) changes. However, Xavier is also right to say that telepathy-python is dead. Review comments: > + if (!contact) In general we prefer "if (contact == NULL)", and blank lines around if/while/for blocks. See <http://telepathy.freedesktop.org/wiki/Style>. I think this also deserves a comment to indicate that the change is for the benefit of obsolete CMs (I added one in the version I committed). Again, please consider using the bug tracking system in future. Thanks, S _______________________________________________ telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
