Hey Dario,
Go for it. The basic idea is good, you will probably have to change some
things here and there while doing the real impl, but the overall idea is ok.
Just one small thing. You should append Channel to all class names, as
in StreamTubeChannel, ...
Once you have something to review please let me know.
BR
Andre
On 24/04/10 09:55, Dario Freddi wrote:
Hello,
please find attached a new version of tp-qt4 high level tubes.
This time they're really high level - I tried keeping the API (and parameters
as well) as similar as possible to tp-qt4 file transfers - it also features
the same mean of creation by using TubeChannelCreationProperties.
My only concern is if it is possible to obtain all the needed properties from
a QIODevice when offering/creating a StreamTube.
(The package does not include the new functions in Account, but they're
obviously there)
Please comment on this one - if you're happy enough, I'll start hacking on
them straight away ;)
On Monday 19 April 2010 19:57:40 Andre Moreira Magalhaes wrote:
On 18/04/10 10:09, Dario Freddi wrote:
Hello all,
as discussed with Andre on IRC, I drafted a small API for managing Tubes
in tp-qt4 (see attachment). There's really nothing fancy here: it's a
quite straightforward mapping of the spec to a Qt-like API, and it's
mostly what tp- glib does as well.
Still, I'd find it cool to provide a function returning a QAbstractSocket
for StreamTubes and a QDBusConnection (or a DBusProxy) for DBusTubes to
make it extremely easy to use the opened tube. I'd like some feedback on
that though, since I don't know how much it would be feasible.
I like the overall idea, but I would change some things as:
- ST and DT should be implemented similarly to FileTransfer channels
where we have Incoming/Outgoing channels depending on the requested
property of the channel.
- For ST you probably want to return a QIODevice on accept, or a
PendingIODevice (you name it) of some sort, so you can instantiate a Qt
Socket object (QLocal/Tcp/UdpSocket) depending on the type of the socket.
You may want to check how FT is implemented in tp-qt4 and get some ideas
from there.
BR
Andre
_______________________________________________
telepathy mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/telepathy
_______________________________________________
telepathy mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/telepathy
