http://bugs.freedesktop.org/show_bug.cgi?id=13158
Sjoerd Simons <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[email protected].|[email protected] |org |k Status|ASSIGNED |NEW --- Comment #3 from Sjoerd Simons <[email protected]> 2009-06-28 06:23:58 PST --- - jingle-transport-iceudp: * parse_candidates: shouldn't stop parsing the candidates when it considers one to be not valid. * parse_candidates: should the foundationtion and use that as the id * inject_candidates: priority usage string seems fine? * inject_candidates: multiple c->preference by 65536 to match tp-fs * inject_candidates: don't invent your own foundation strings, tp-fs gives them to you as the candidate id in NewNativeCandidate * inject_candidates: don't assert when you get a candidate type you don't expect * inject_candidates: don't assert when you get a protocol you don't expect * inject_candidates: What's the name attribute for the candidate? * new_local_candidates: state variable is retrieved but never used - jingle-transport-rawudp: * parse_candidates: - FIXME : you don't care about stun vs. local * inject_candidates: id == c->username ?? * new_local_candites: state variable retrieved but not used * new_local_candites: you can assert that pending_candidates == NULL if priv->local_candidates was NULL * new_local_candidates && can_accept: nitpick: this only works correctly because tp-fs gives exactly one rtp and one rtcp candidate in one call to NewNativeCandidate and only calls that once with the best candidate (i think). In a prefect world we'd batch all the candidates untill NativeCandidatesPrepared is called and then pick the highest preference rtp candidate to send out. (and error out if there is no rtp candidate) -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
