2009/6/16 George Kiagiadakis <[email protected]>: > 2009/6/15 Andre Moreira Magalhaes <[email protected]>: >> George Kiagiadakis wrote: >>> Patch 0002 makes ClientApproverAdaptor use the full name of the Connection >>> property ("org.freedesktop.Telepathy.ChannelDispatchOperation.Connection") >>> to read the Connection object path from the properties that are passed to >>> its AddDispatchOperation method, in order to compy with the spec. Before I >>> fix that, it would crash a while after the channel dispatcher had called >>> this method, because the Connection object was assumed to be valid, although >>> it wasn't. >>> >>> >> >> This is wrong, the property _is_ Connection as stated on the spec: >> | >> Properties| - |a{sv}| (Qualified_Property_Value_Map >> <http://telepathy.freedesktop.org/spec.html#type-Qualified_Property_Value_Map>) >> >> Properties of the channel dispatch operation. This MUST NOT include >> properties that could change, SHOULD include as many properties as >> possible given that constraint, and MUST include at least the >> Account >> >> <http://telepathy.freedesktop.org/spec.html#org.freedesktop.Telepathy.ChannelDispatchOperation.Account>, >> Connection >> >> <http://telepathy.freedesktop.org/spec.html#org.freedesktop.Telepathy.ChannelDispatchOperation.Connection> >> and PossibleHandlers >> >> <http://telepathy.freedesktop.org/spec.html#org.freedesktop.Telepathy.ChannelDispatchOperation.PossibleHandlers> >> properties. >> If your CD version is giving you a different property, it's wrong, and the >> CD must be fixed. What CD (MC) version are you using? We can discuss this on >> #telepa...@freenode if you prefer. > > I am using mission-control 5.1.0 (git checkout from the 5.1.0 tag). I > put a debug() << properties; statement there and I saw that it passes > all those properties prefixed with the interface name. That is: > "org.freedesktop.Telepathy.ChannelDispatchOperation.Account" (not just > "Account"), > "org.freedesktop.Telepathy.ChannelDispatchOperation.Connection" (not > just "Connection") > etc...
Hi again, I was about to report this bug now to mission-control, but then I noticed a detail in the spec: In http://telepathy.freedesktop.org/spec.html#type-Qualified_Property_Value_Map it says: Key - s (DBus_Qualified_Member) A D-Bus interface name, followed by a dot and a D-Bus property name. And notice that the Properties passed to this method (AddDispatchOperation) are of this type: Properties - a{sv} (Qualified_Property_Value_Map) So, it seems that the property names MUST be prefixed by the interface name, followed by a dot. So, mission-control is doing the correct thing here... What do you think? Regards, George _______________________________________________ telepathy mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/telepathy
