On Thu, Sep 07, 2023 at 11:58:03PM +0200, Mark Kettenis wrote:
> > Date: Thu, 7 Sep 2023 22:02:12 +0200
> > From: Matthieu Herrb <matth...@openbsd.org>
> >
> > basically just define the CARDnn types in terms on uint_nn everywhere.
> > Like for signal.h all systems still supported by X have stdint and the
> > uintnn_t types.
>
> The problem with this is that you're changing the type of CARD32 and
> CARD64. Which means that if these types are used in C++ code, the
> mangling changes, and therefore you risk breaking the ABI. And I bet
> you there is C++ code that uses the CARD32 and CARD64 types.
>
> How did the commit break the tree? The actual error messages were
> never mailed out as far as I can tell.
>
> I think you should simply revert to the pre-hackathon state.
Done. Indeed this needs more thinking. I've reverted those commits.
Here are the errors with llvm 16 on the tree before p2k23 (and
-current)
in xserver/glamor_egl:
libtool: compile: /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/glamor_egl -I../../../include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/common
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bus
-I/local/OpenBSD/xenocara/xserver/os -I/local/OpenBSD/xenocara/xserver/dri3
-I/local/OpenBSD/xenocara/xserver/glamor -DHAVE_DIX_CONFIG_H -Wall
-Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes
-Wmissing-prototypes -Wnested-externs -Wbad-function-cast
-Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized
-Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls
-Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-fno-strict-aliasing -I/usr/X11R6/include -D_DEFAULT_SOURCE -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R6/include/X11/dri
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include/pixman-1
-I/usr/X11R6/include/freetype2 -I/local/OpenBSD/xenocara/xserver/include
-I../../../include -I/local/OpenBSD/xenocara/xserver/Xext
-I/local/OpenBSD/xenocara/xserver/composite
-I/local/OpenBSD/xenocara/xserver/damageext
-I/local/OpenBSD/xenocara/xserver/xfixes -I/local/OpenBSD/xenocara/xserver/Xi
-I/local/OpenBSD/xenocara/xserver/mi
-I/local/OpenBSD/xenocara/xserver/miext/sync
-I/local/OpenBSD/xenocara/xserver/miext/shadow
-I/local/OpenBSD/xenocara/xserver/miext/damage
-I/local/OpenBSD/xenocara/xserver/render
-I/local/OpenBSD/xenocara/xserver/randr -I/local/OpenBSD/xenocara/xserver/fb
-I/local/OpenBSD/xenocara/xserver/dbe -I/local/OpenBSD/xenocara/xserver/present
-fvisibility=hidden -I/usr/X11R6/include -DHAVE_XORG_CONFIG_H
-fvisibility=hidden -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -O2 -pipe -pthread -c
/local/OpenBSD/xenocara/xserver/glamor/glamor_egl.c -fPIC -DPIC -o
.libs/glamor_egl.o
/local/OpenBSD/xenocara/xserver/glamor/glamor_egl.c:849:24: error: incompatible
function pointer types initializing 'dri3_pixmap_from_fds_proc' (aka 'struct
_Pixmap *(*)(struct _Screen *, unsigned char, const int *, unsigned short,
unsigned short, const unsigned int *, const unsigned int *, unsigned char,
unsigned char, unsigned long)') with an expression of type 'PixmapPtr
(ScreenPtr, CARD8, const int *, CARD16, CARD16, const CARD32 *, const CARD32 *,
CARD8, CARD8, uint64_t)' (aka 'struct _Pixmap *(struct _Screen *, unsigned
char, const int *, unsigned short, unsigned short, const unsigned int *, const
unsigned int *, unsigned char, unsigned char, unsigned long long)')
[-Wincompatible-function-pointer-types]
.pixmap_from_fds = glamor_pixmap_from_fds,
^~~~~~~~~~~~~~~~~~~~~~
1 error generated.
*** Error 1 in xserver/obj/hw/xfree86/glamor_egl (Makefile:635 'glamor_egl.lo')
in xserver/hw/xfree86/drivers/modesetting:
source='/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/dri2.c'
object='dri2.lo' libtool=yes DEPDIR=.deps depmode=none /bin/sh
/local/OpenBSD/xenocara/xserver/depcomp /bin/sh ../../../../libtool --tag=CC
--mode=compile /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting
-I../../../../include -I/local/OpenBSD/xenocara/xserver/hw/xfree86
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/common
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bus
-I/local/OpenBSD/xenocara/xserver/os -I/local/OpenBSD/xenocara/xserver/glamor
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ddc
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../dri2
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../i2c
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../modes
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../parser
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ramdac
-DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2
-Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast
-Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized
-Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls
-Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-fno-strict-aliasing -I/usr/X11R6/include -D_DEFAULT_SOURCE -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R6/include/X11/dri
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include/pixman-1
-I/usr/X11R6/include/freetype2 -I/local/OpenBSD/xenocara/xserver/include
-I../../../../include -I/local/OpenBSD/xenocara/xserver/Xext
-I/local/OpenBSD/xenocara/xserver/composite
-I/local/OpenBSD/xenocara/xserver/damageext
-I/local/OpenBSD/xenocara/xserver/xfixes -I/local/OpenBSD/xenocara/xserver/Xi
-I/local/OpenBSD/xenocara/xserver/mi
-I/local/OpenBSD/xenocara/xserver/miext/sync
-I/local/OpenBSD/xenocara/xserver/miext/shadow
-I/local/OpenBSD/xenocara/xserver/miext/damage
-I/local/OpenBSD/xenocara/xserver/render
-I/local/OpenBSD/xenocara/xserver/randr -I/local/OpenBSD/xenocara/xserver/fb
-I/local/OpenBSD/xenocara/xserver/dbe -I/local/OpenBSD/xenocara/xserver/present
-fvisibility=hidden -I/usr/X11R6/include -DHAVE_XORG_CONFIG_H
-fvisibility=hidden -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -Wall -Wpointer-arith -Wmissing-declarations
-Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement
-Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
-Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self
-Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-O2 -pipe -pthread -c -o dri2.lo
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/dri2.c
libtool: compile: /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting
-I../../../../include -I/local/OpenBSD/xenocara/xserver/hw/xfree86
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/common
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bus
-I/local/OpenBSD/xenocara/xserver/os -I/local/OpenBSD/xenocara/xserver/glamor
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ddc
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../dri2
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../i2c
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../modes
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../parser
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ramdac
-DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2
-Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast
-Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized
-Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls
-Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-fno-strict-aliasing -I/usr/X11R6/include -D_DEFAULT_SOURCE -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R6/include/X11/dri
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include/pixman-1
-I/usr/X11R6/include/freetype2 -I/local/OpenBSD/xenocara/xserver/include
-I../../../../include -I/local/OpenBSD/xenocara/xserver/Xext
-I/local/OpenBSD/xenocara/xserver/composite
-I/local/OpenBSD/xenocara/xserver/damageext
-I/local/OpenBSD/xenocara/xserver/xfixes -I/local/OpenBSD/xenocara/xserver/Xi
-I/local/OpenBSD/xenocara/xserver/mi
-I/local/OpenBSD/xenocara/xserver/miext/sync
-I/local/OpenBSD/xenocara/xserver/miext/shadow
-I/local/OpenBSD/xenocara/xserver/miext/damage
-I/local/OpenBSD/xenocara/xserver/render
-I/local/OpenBSD/xenocara/xserver/randr -I/local/OpenBSD/xenocara/xserver/fb
-I/local/OpenBSD/xenocara/xserver/dbe -I/local/OpenBSD/xenocara/xserver/present
-fvisibility=hidden -I/usr/X11R6/include -DHAVE_XORG_CONFIG_H
-fvisibility=hidden -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -Wall -Wpointer-arith -Wmissing-declarations
-Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement
-Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
-Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self
-Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-O2 -pipe -pthread -c
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/dri2.c -fPIC
-DPIC -o .libs/dri2.o
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/dri2.c:871:37:
warning: incompatible pointer types passing 'uint64_t *' (aka 'unsigned long
long *') to parameter of type 'CARD64 *' (aka 'unsigned long *')
[-Wincompatible-pointer-types]
ret = ms_get_crtc_ust_msc(crtc, ¤t_ust, ¤t_msc);
^~~~~~~~~~~~
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/driver.h:210:51:
note: passing argument to parameter 'ust' here
int ms_get_crtc_ust_msc(xf86CrtcPtr crtc, CARD64 *ust, CARD64 *msc);
^
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/dri2.c:871:51:
warning: incompatible pointer types passing 'uint64_t *' (aka 'unsigned long
long *') to parameter of type 'CARD64 *' (aka 'unsigned long *')
[-Wincompatible-pointer-types]
ret = ms_get_crtc_ust_msc(crtc, ¤t_ust, ¤t_msc);
^~~~~~~~~~~~
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/driver.h:210:64:
note: passing argument to parameter 'msc' here
int ms_get_crtc_ust_msc(xf86CrtcPtr crtc, CARD64 *ust, CARD64 *msc);
^
2 warnings generated.
source='/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/present.c'
object='present.lo' libtool=yes DEPDIR=.deps depmode=none /bin/sh
/local/OpenBSD/xenocara/xserver/depcomp /bin/sh ../../../../libtool --tag=CC
--mode=compile /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting
-I../../../../include -I/local/OpenBSD/xenocara/xserver/hw/xfree86
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/common
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bus
-I/local/OpenBSD/xenocara/xserver/os -I/local/OpenBSD/xenocara/xserver/glamor
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ddc
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../dri2
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../i2c
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../modes
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../parser
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ramdac
-DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2
-Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast
-Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized
-Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls
-Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-fno-strict-aliasing -I/usr/X11R6/include -D_DEFAULT_SOURCE -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R6/include/X11/dri
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include/pixman-1
-I/usr/X11R6/include/freetype2 -I/local/OpenBSD/xenocara/xserver/include
-I../../../../include -I/local/OpenBSD/xenocara/xserver/Xext
-I/local/OpenBSD/xenocara/xserver/composite
-I/local/OpenBSD/xenocara/xserver/damageext
-I/local/OpenBSD/xenocara/xserver/xfixes -I/local/OpenBSD/xenocara/xserver/Xi
-I/local/OpenBSD/xenocara/xserver/mi
-I/local/OpenBSD/xenocara/xserver/miext/sync
-I/local/OpenBSD/xenocara/xserver/miext/shadow
-I/local/OpenBSD/xenocara/xserver/miext/damage
-I/local/OpenBSD/xenocara/xserver/render
-I/local/OpenBSD/xenocara/xserver/randr -I/local/OpenBSD/xenocara/xserver/fb
-I/local/OpenBSD/xenocara/xserver/dbe -I/local/OpenBSD/xenocara/xserver/present
-fvisibility=hidden -I/usr/X11R6/include -DHAVE_XORG_CONFIG_H
-fvisibility=hidden -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -Wall -Wpointer-arith -Wmissing-declarations
-Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement
-Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
-Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self
-Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-O2 -pipe -pthread -c -o present.lo
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/present.c
libtool: compile: /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting
-I../../../../include -I/local/OpenBSD/xenocara/xserver/hw/xfree86
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/common
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bus
-I/local/OpenBSD/xenocara/xserver/os -I/local/OpenBSD/xenocara/xserver/glamor
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ddc
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../dri2
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../i2c
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../modes
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../parser
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ramdac
-DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2
-Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast
-Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized
-Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls
-Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-fno-strict-aliasing -I/usr/X11R6/include -D_DEFAULT_SOURCE -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R6/include/X11/dri
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include/pixman-1
-I/usr/X11R6/include/freetype2 -I/local/OpenBSD/xenocara/xserver/include
-I../../../../include -I/local/OpenBSD/xenocara/xserver/Xext
-I/local/OpenBSD/xenocara/xserver/composite
-I/local/OpenBSD/xenocara/xserver/damageext
-I/local/OpenBSD/xenocara/xserver/xfixes -I/local/OpenBSD/xenocara/xserver/Xi
-I/local/OpenBSD/xenocara/xserver/mi
-I/local/OpenBSD/xenocara/xserver/miext/sync
-I/local/OpenBSD/xenocara/xserver/miext/shadow
-I/local/OpenBSD/xenocara/xserver/miext/damage
-I/local/OpenBSD/xenocara/xserver/render
-I/local/OpenBSD/xenocara/xserver/randr -I/local/OpenBSD/xenocara/xserver/fb
-I/local/OpenBSD/xenocara/xserver/dbe -I/local/OpenBSD/xenocara/xserver/present
-fvisibility=hidden -I/usr/X11R6/include -DHAVE_XORG_CONFIG_H
-fvisibility=hidden -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -Wall -Wpointer-arith -Wmissing-declarations
-Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement
-Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
-Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self
-Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-O2 -pipe -pthread -c
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/present.c -fPIC
-DPIC -o .libs/present.o
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/present.c:444:20:
error: incompatible function pointer types initializing
'present_get_ust_msc_ptr' (aka 'int (*)(struct _rrCrtc *, unsigned long long *,
unsigned long long *)') with an expression of type 'int (RRCrtcPtr, CARD64 *,
CARD64 *)' (aka 'int (struct _rrCrtc *, unsigned long *, unsigned long *)')
[-Wincompatible-function-pointer-types]
.get_ust_msc = ms_present_get_ust_msc,
^~~~~~~~~~~~~~~~~~~~~~
1 error generated.
*** Error 1 in target 'present.lo', line 693 of Makefile (continuing)
source='/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/vblank.c'
object='vblank.lo' libtool=yes DEPDIR=.deps depmode=none /bin/sh
/local/OpenBSD/xenocara/xserver/depcomp /bin/sh ../../../../libtool --tag=CC
--mode=compile /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting
-I../../../../include -I/local/OpenBSD/xenocara/xserver/hw/xfree86
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/common
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bus
-I/local/OpenBSD/xenocara/xserver/os -I/local/OpenBSD/xenocara/xserver/glamor
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ddc
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../dri2
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../i2c
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../modes
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../parser
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ramdac
-DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2
-Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast
-Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized
-Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls
-Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-fno-strict-aliasing -I/usr/X11R6/include -D_DEFAULT_SOURCE -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R6/include/X11/dri
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include/pixman-1
-I/usr/X11R6/include/freetype2 -I/local/OpenBSD/xenocara/xserver/include
-I../../../../include -I/local/OpenBSD/xenocara/xserver/Xext
-I/local/OpenBSD/xenocara/xserver/composite
-I/local/OpenBSD/xenocara/xserver/damageext
-I/local/OpenBSD/xenocara/xserver/xfixes -I/local/OpenBSD/xenocara/xserver/Xi
-I/local/OpenBSD/xenocara/xserver/mi
-I/local/OpenBSD/xenocara/xserver/miext/sync
-I/local/OpenBSD/xenocara/xserver/miext/shadow
-I/local/OpenBSD/xenocara/xserver/miext/damage
-I/local/OpenBSD/xenocara/xserver/render
-I/local/OpenBSD/xenocara/xserver/randr -I/local/OpenBSD/xenocara/xserver/fb
-I/local/OpenBSD/xenocara/xserver/dbe -I/local/OpenBSD/xenocara/xserver/present
-fvisibility=hidden -I/usr/X11R6/include -DHAVE_XORG_CONFIG_H
-fvisibility=hidden -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -Wall -Wpointer-arith -Wmissing-declarations
-Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement
-Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
-Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self
-Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-O2 -pipe -pthread -c -o vblank.lo
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/vblank.c
libtool: compile: /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting
-I../../../../include -I/local/OpenBSD/xenocara/xserver/hw/xfree86
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/include
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/common
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/os-support/bus
-I/local/OpenBSD/xenocara/xserver/os -I/local/OpenBSD/xenocara/xserver/glamor
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ddc
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../dri2
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../i2c
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../modes
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../parser
-I/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/../../ramdac
-DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2
-Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast
-Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized
-Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls
-Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main
-Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-fno-strict-aliasing -I/usr/X11R6/include -D_DEFAULT_SOURCE -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/usr/X11R6/include/X11/dri
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include/pixman-1
-I/usr/X11R6/include/freetype2 -I/local/OpenBSD/xenocara/xserver/include
-I../../../../include -I/local/OpenBSD/xenocara/xserver/Xext
-I/local/OpenBSD/xenocara/xserver/composite
-I/local/OpenBSD/xenocara/xserver/damageext
-I/local/OpenBSD/xenocara/xserver/xfixes -I/local/OpenBSD/xenocara/xserver/Xi
-I/local/OpenBSD/xenocara/xserver/mi
-I/local/OpenBSD/xenocara/xserver/miext/sync
-I/local/OpenBSD/xenocara/xserver/miext/shadow
-I/local/OpenBSD/xenocara/xserver/miext/damage
-I/local/OpenBSD/xenocara/xserver/render
-I/local/OpenBSD/xenocara/xserver/randr -I/local/OpenBSD/xenocara/xserver/fb
-I/local/OpenBSD/xenocara/xserver/dbe -I/local/OpenBSD/xenocara/xserver/present
-fvisibility=hidden -I/usr/X11R6/include -DHAVE_XORG_CONFIG_H
-fvisibility=hidden -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -I/usr/X11R6/include -I/usr/X11R6/include
-I/usr/X11R6/include/libdrm -Wall -Wpointer-arith -Wmissing-declarations
-Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement
-Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
-Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self
-Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type
-Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address
-Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing
-O2 -pipe -pthread -c
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/vblank.c -fPIC
-DPIC -o .libs/vblank.o
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/vblank.c:377:51:
warning: incompatible pointer types passing 'CARD64 *' (aka 'unsigned long *')
to parameter of type 'uint64_t *' (aka 'unsigned long long *')
[-Wincompatible-pointer-types]
if (!ms_get_kernel_ust_msc(crtc, &kernel_msc, ust))
^~~
/local/OpenBSD/xenocara/xserver/hw/xfree86/drivers/modesetting/vblank.c:225:48:
note: passing argument to parameter 'ust' here
uint64_t *msc, uint64_t *ust)
^
1 warning generated.
and drivers/xf86-video-amdgpu/src/amdgpu_present.c
source='/local/OpenBSD/xenocara/driver/xf86-video-amdgpu/src/amdgpu_present.c'
object='amdgpu_present.lo' libtool=yes DEPDIR=.deps depmode=none /bin/sh
/local/OpenBSD/xenocara/driver/xf86-video-amdgpu/depcomp /bin/sh ../libtool
--tag=CC --mode=compile /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/driver/xf86-video-amdgpu/src -I.. -Wall
-I/usr/X11R6/include -I/usr/X11R6/include -I/usr/X11R6/include/libdrm
-I/usr/X11R6/include/xorg -fvisibility=hidden -I/usr/X11R6/include
-I/usr/X11R6/include/pixman-1 -I/usr/X11R6/include/libdrm
-I/usr/X11R6/include/X11/dri -O2 -pipe -c -o amdgpu_present.lo
/local/OpenBSD/xenocara/driver/xf86-video-amdgpu/src/amdgpu_present.c
libtool: compile: /usr/local/bin/clang-16 -DHAVE_CONFIG_H -I.
-I/local/OpenBSD/xenocara/driver/xf86-video-amdgpu/src -I.. -Wall
-I/usr/X11R6/include -I/usr/X11R6/include -I/usr/X11R6/include/libdrm
-I/usr/X11R6/include/xorg -fvisibility=hidden -I/usr/X11R6/include
-I/usr/X11R6/include/pixman-1 -I/usr/X11R6/include/libdrm
-I/usr/X11R6/include/X11/dri -O2 -pipe -c
/local/OpenBSD/xenocara/driver/xf86-video-amdgpu/src/amdgpu_present.c -fPIC
-DPIC -o .libs/amdgpu_present.o
/local/OpenBSD/xenocara/driver/xf86-video-amdgpu/src/amdgpu_present.c:455:17:
error: incompatible function pointer types initializing
'present_get_ust_msc_ptr' (aka 'int (*)(struct _rrCrtc *, unsigned long long *,
unsigned long long *)') with an expression of type 'int (RRCrtcPtr, CARD64 *,
CARD64 *)' (aka 'int (struct _rrCrtc *, unsigned long *, unsigned long *)')
[-Wincompatible-function-pointer-types]
.get_ust_msc = amdgpu_present_get_ust_msc,
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
--
Matthieu Herrb
