On Fri, Feb 24, 2023 at 06:05:21PM +0100, Claudio Jeker wrote: > For those people who enjoy pain here some code that allows bgpd to load > ASPA records from a very current StayRTR cache. > > This implements mostly what draft-ietf-sidrops-8210bis-10 specifies. > Now the version negotiation is a hot mess and the result is not pretty.
Wow, this is complicated. Seems correct to me, however. > In rtr.c most change is because I renamed rtr_aspa_merge_set() to > rtr_aspa_insert() and I moved the code up to rtr_roa_insert(). > > In rtr_proto.c most complexity comes from the version negotiation. The > ASPA parser is reasonably streight forward. Indeed. > While there are no immediate fireworks with this on the latest StayRTR > using any of the StayRTR / GoRTR releases with this triggers a bug on the > RTR cache and with that version negotiation fails in most cases. > So best run bleeding edge with bleeding edge. Reads perfectly fine. Again could not spot anything to nitpick. ok tb