On Mon, Jan 23, 2023 at 02:11:14PM +0300, Vitaliy Makkoveev wrote:
> It's overkilling.
mpi@ added this kassert when he introduced the so parameter for
sb_notify() and sbspace().
It never triggered, so feel free to remove it.
OK bluhm@
> Index: sys/sys/socketvar.h
> ===================================================================
> RCS file: /cvs/src/sys/sys/socketvar.h,v
> retrieving revision 1.116
> diff -u -p -r1.116 socketvar.h
> --- sys/sys/socketvar.h 22 Jan 2023 12:05:44 -0000 1.116
> +++ sys/sys/socketvar.h 23 Jan 2023 11:07:00 -0000
> @@ -199,7 +199,6 @@ sorele(struct socket *so)
> static inline int
> sb_notify(struct socket *so, struct sockbuf *sb)
> {
> - KASSERT(sb == &so->so_rcv || sb == &so->so_snd);
> soassertlocked(so);
> return ((sb->sb_flags & (SB_WAIT|SB_ASYNC|SB_SPLICE)) != 0 ||
> !klist_empty(&sb->sb_sel.si_note));
> @@ -214,7 +213,6 @@ sb_notify(struct socket *so, struct sock
> static inline long
> sbspace(struct socket *so, struct sockbuf *sb)
> {
> - KASSERT(sb == &so->so_rcv || sb == &so->so_snd);
> soassertlocked(so);
> return lmin(sb->sb_hiwat - sb->sb_cc, sb->sb_mbmax - sb->sb_mbcnt);
> }
