On Tue, Jan 17, 2023 at 04:48:06PM +0100, Theo Buehler wrote:
> On Tue, Jan 17, 2023 at 03:11:26PM +0100, Claudio Jeker wrote:
> > This diff adds all the plumbing to push the ASPA table from the RTR
> > process into the RDE. It is still missing important bits but the table
> > itself should load and `bgpctl show sets` will show what was loaded.
> > 
> > After that the reload logic needs to be added and the filters need to
> > be extended to check the ASPA validation state.
> 
> Please commit the diff at the end to fix regress when you land this
> (needed because of the new getmonotime() call in aspa_table_prep()).

I will just add getmonotime() as stub function to the regress.
 
> This generally reads fine. There is a crash in rde_aspa_reload(),
> see comments inline. If you agree with my suggested fix, this is ok tb

Yes, I agree with your fix. Will commit once I fixed all other issues as
well. Thanks.
 
-- 
:wq Claudio

Reply via email to