On Fri, Jan 06, 2023 at 09:46:13PM +0100, Mathias Koehler wrote: > lines 1911 - 1913 and 1917 - 1919 are code blocks that are looking > identical. I cannot imagine that that is on purpose. What do you > really wanna express here?
Just quoting line numbers does not help a lot. You were looking at the code, so quote the lines, making things easier for the readers of the list. Looking at the cvs history it seems it was simply overlooked the two blocks are the same. The best way to approach this is to come up with a diff. The makes your message explicit and helps to improve the code base. If the two blocks should *not* be the same, it is very likely a developer with knowledge of this area will be triggered by a diff as well. In short: we prefer to talk in diffs, because there are explicit, actionable, not ambiguous and so focus the discourse. -Otto