A while ago I added ENTRY_NB to i386 to fix some warnings in libm. Turns
out that libc also has a few of them on i386, diff below fixes the

warning: bcopy changed binding to STB_WEAK

for bcmp, bzero, bcopy, brk, sbrk.

http://bluhm.genua.de/regress/results/2022-12-02T15%3A17%3A04Z/setup-ot4.log
is a build log containing the warnings.

Index: lib/libc/arch/i386/string/bcmp.S
===================================================================
RCS file: /cvs/src/lib/libc/arch/i386/string/bcmp.S,v
retrieving revision 1.5
diff -u -p -r1.5 bcmp.S
--- lib/libc/arch/i386/string/bcmp.S    29 Nov 2017 05:13:57 -0000      1.5
+++ lib/libc/arch/i386/string/bcmp.S    3 Dec 2022 01:00:48 -0000
@@ -6,7 +6,7 @@
 
 #include "DEFS.h"
 
-ENTRY(bcmp)
+ENTRY_NB(bcmp)
        pushl   %edi
        pushl   %esi
        movl    12(%esp),%edi
Index: lib/libc/arch/i386/string/bzero.S
===================================================================
RCS file: /cvs/src/lib/libc/arch/i386/string/bzero.S,v
retrieving revision 1.6
diff -u -p -r1.6 bzero.S
--- lib/libc/arch/i386/string/bzero.S   29 Nov 2017 05:13:57 -0000      1.6
+++ lib/libc/arch/i386/string/bzero.S   3 Dec 2022 01:01:38 -0000
@@ -6,7 +6,7 @@
 
 #include "DEFS.h"
 
-ENTRY(bzero)
+ENTRY_NB(bzero)
        pushl   %edi
        movl    8(%esp),%edi
        movl    12(%esp),%edx
Index: lib/libc/arch/i386/string/memmove.S
===================================================================
RCS file: /cvs/src/lib/libc/arch/i386/string/memmove.S,v
retrieving revision 1.7
diff -u -p -r1.7 memmove.S
--- lib/libc/arch/i386/string/memmove.S 29 Nov 2017 05:13:57 -0000      1.7
+++ lib/libc/arch/i386/string/memmove.S 3 Dec 2022 01:01:28 -0000
@@ -39,7 +39,7 @@
  * Emulate bcopy() by swapping the first two arguments, and jumping
  * into memmove(), which handles overlapping regions.
  */
-ENTRY(bcopy)
+ENTRY_NB(bcopy)
        pushl   %esi
        pushl   %edi
        movl    12(%esp),%esi
Index: lib/libc/arch/i386/sys/brk.S
===================================================================
RCS file: /cvs/src/lib/libc/arch/i386/sys/brk.S,v
retrieving revision 1.14
diff -u -p -r1.14 brk.S
--- lib/libc/arch/i386/sys/brk.S        25 Oct 2021 14:38:10 -0000      1.14
+++ lib/libc/arch/i386/sys/brk.S        3 Dec 2022 01:02:43 -0000
@@ -42,7 +42,7 @@ __minbrk:
        END(__minbrk)
        .type   __minbrk,@object
 
-ENTRY(brk)
+ENTRY_NB(brk)
 #ifdef __PIC__
        movl    4(%esp),%ecx
        PIC_PROLOGUE
Index: lib/libc/arch/i386/sys/sbrk.S
===================================================================
RCS file: /cvs/src/lib/libc/arch/i386/sys/sbrk.S,v
retrieving revision 1.14
diff -u -p -r1.14 sbrk.S
--- lib/libc/arch/i386/sys/sbrk.S       25 Oct 2021 14:38:10 -0000      1.14
+++ lib/libc/arch/i386/sys/sbrk.S       3 Dec 2022 01:02:56 -0000
@@ -42,7 +42,7 @@ __curbrk:     .long   _end
        END(__curbrk)
        .type   __curbrk,@object
 
-ENTRY(sbrk)
+ENTRY_NB(sbrk)
 #ifdef __PIC__
        movl    4(%esp),%ecx
        PIC_PROLOGUE

Reply via email to