Hi,

yes, this is completely correct, with one tiny exception that should
be fixed while committing, see in-line below.

Jason, since you already started working on this, could you please
commit this patch with OK schwarze@?

I'm surprised there was still so much .Li in our tree where .Vt
should have been.  These are not even edge cases but completely
unambiguous .Vt.

Note that the mdoc(7) manual deprecates .Li (it is a presentational
macro with an invisible effect - we usually want semantic rather
than presentational markup).  Rare cases exist where it may not be
completely obvious what to use instead, but here it is.

Thanks,
  Ingo


Josiah Frentsos wrote on Sat, Sep 10, 2022 at 12:29:28PM -0400:

> Index: lib/libc/gen/frexp.3
> Index: lib/libc/gen/getgrent.3
> Index: lib/libc/gen/getpwent.3
> Index: lib/libc/gen/getpwnam.3
> Index: lib/libc/gen/glob.3
> Index: lib/libc/gen/isalnum.3
> Index: lib/libc/gen/isalpha.3
> Index: lib/libc/gen/isblank.3
> Index: lib/libc/gen/iscntrl.3
> Index: lib/libc/gen/isdigit.3
> Index: lib/libc/gen/isgraph.3
> Index: lib/libc/gen/islower.3
> Index: lib/libc/gen/isprint.3
> Index: lib/libc/gen/ispunct.3
> Index: lib/libc/gen/isspace.3
> Index: lib/libc/gen/isupper.3
> Index: lib/libc/gen/isxdigit.3
> Index: lib/libc/gen/lockf.3
> Index: lib/libc/gen/login_cap.3
> Index: lib/libc/gen/modf.3
> Index: lib/libc/gen/opendir.3
> Index: lib/libc/gen/setjmp.3
> Index: lib/libc/gen/times.3
> Index: lib/libc/gen/tolower.3
> Index: lib/libc/gen/toupper.3
> Index: lib/libc/gen/uname.3
> Index: lib/libc/gen/utime.3
> Index: lib/libc/locale/localeconv.3
> Index: lib/libc/net/ether_aton.3
> Index: lib/libc/net/getaddrinfo.3
> Index: lib/libc/net/getnameinfo.3
> Index: lib/libc/net/getpeereid.3
> Index: lib/libc/net/getrrsetbyname.3
> Index: lib/libc/net/htonl.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/net/htonl.3,v
> retrieving revision 1.5
> diff -u -p -r1.5 htonl.3
> --- lib/libc/net/htonl.3      13 Feb 2019 07:02:09 -0000      1.5
> +++ lib/libc/net/htonl.3      10 Sep 2022 16:10:01 -0000
> @@ -66,14 +66,14 @@ or
>  .Sq l )
>  is a mnemonic
>  for the traditional names for such quantities,
> -.Li short
> +.Vt short
>  and
> -.Li long ,
> +.Vt long ,
>  respectively.

This is misleading, as explained in the very next sentence.
I suggest just dropping the .Li markup in these two instances
without any replacement, or .Dq if you insist on some markup.

>  Today, the C concept of
> -.Li short
> +.Vt short
>  and
> -.Li long
> +.Vt long
>  integers need not coincide with this traditional misunderstanding.
>  On machines which have a byte order which is the same as the network
>  order, routines are defined as null macros.

This part is correct.

> Index: lib/libc/net/inet_addr.3
> Index: lib/libc/net/inet_net_ntop.3
> Index: lib/libc/net/inet_ntop.3
> Index: lib/libc/regex/regex.3
> Index: lib/libc/rpc/xdr.3
> Index: lib/libc/stdio/fseek.3
> Index: lib/libc/stdio/getc.3
> Index: lib/libc/stdio/putc.3
> Index: lib/libc/stdio/ungetc.3
> Index: lib/libc/stdlib/atof.3
> Index: lib/libc/stdlib/atoi.3
> Index: lib/libc/stdlib/atol.3
> Index: lib/libc/stdlib/atoll.3
> Index: lib/libc/stdlib/div.3
> Index: lib/libc/stdlib/getopt_long.3
> Index: lib/libc/stdlib/imaxdiv.3
> Index: lib/libc/stdlib/ldiv.3
> Index: lib/libc/stdlib/lldiv.3
> Index: lib/libc/stdlib/strtod.3
> Index: lib/libc/stdlib/strtonum.3
> Index: lib/libc/string/memccpy.3
> Index: lib/libc/string/memchr.3
> Index: lib/libc/string/memcmp.3
> Index: lib/libc/string/memset.3
> Index: lib/libc/sys/accept.2
> Index: lib/libc/sys/fcntl.2
> Index: lib/libc/sys/getpeername.2
> Index: lib/libc/sys/getrlimit.2
> Index: lib/libc/sys/getsockname.2
> Index: lib/libc/sys/getsockopt.2
> Index: lib/libc/sys/ioctl.2
> Index: lib/libc/sys/ptrace.2
> Index: lib/libc/sys/quotactl.2
> Index: lib/libc/termios/tcsetattr.3
> Index: lib/libc/time/ctime.3
> Index: lib/libradius/radius_new_request_packet.3
> Index: share/man/man3/bit_alloc.3
> Index: share/man/man3/dl_iterate_phdr.3
> Index: share/man/man4/bpf.4
> Index: share/man/man4/ddb.4
> Index: share/man/man4/openprom.4
> Index: share/man/man4/options.4
> Index: share/man/man4/speaker.4
> Index: share/man/man5/ranlib.5
> Index: share/man/man8/crash.8
> Index: share/man/man9/printf.9
> Index: share/man/man9/socreate.9
> Index: share/man/man9/style.9
> Index: usr.bin/ssh/sshd.8
> Index: usr.sbin/zdump/zdump.8

Reply via email to