Hi Claudio,

This looks mostly OK, just a few nit:

On Fri, Sep 02, 2022 at 10:02:33PM +0200, Claudio Jeker wrote:
> @@ -1223,8 +1224,26 @@ repo_check_timeout(int timeout)
>  {
>       struct repo     *rp;
>       time_t           now;
> +     int              diff;
>  
>       now = getmonotime();
> +
> +     /* check against our runtime deadline first */
> +     if (deadline != 0) {
> +             if (deadline <= now) {
> +                     warnx("deadline reached, giving up on repository sync");

It might be better to avoid executing this code path when 'noop' (-n) is
enabled?

Other than that - OK

Kind regards,

Job

Reply via email to