On Mon, Apr 11, 2022 at 07:37:51PM +0200, Theo Buehler wrote:
> On Mon, Apr 11, 2022 at 05:11:30PM +0000, Job Snijders wrote:
> > On Mon, Apr 11, 2022 at 06:46:20PM +0200, Theo Buehler wrote:
> > > Is this base64 blob really useful? The exact same thing is contained in
> > > a more readable fashion (i.e. with line breaks) in the .tal file itself.
> >
> > OK, cat(1) can also be used indeed :-)
> >
> > > Apart from that, I'm fine with having something like this. Couple
> > > comments inline
> >
> > $ rpki-client -f /etc/rpki/ripe.tal
> > File: /etc/rpki/ripe.tal
> > Trust anchor name: ripe
> > Subject key identifier:
> > E8:55:2B:1F:D6:D1:A4:F7:E4:04:C6:D8:E5:68:0D:1E:BC:16:3F:C3
>
> I should have pointed this out before... This is 83 characters wide, so
> maybe we should use a line break. Perhaps
>
> printf("Subject key identifier:\n\*s%s\n", 7, "", pretty_key_id(ski));
>
> to align it with the URIs would look nicer.
>
> I'm ok with either variant but please give claudio a chance to comment.
>
I'm fine with either version. I think keeping it on one line has benefits
if the output is processed by something afterwards. A third option is to
shorten "Subject key identifier"
--
:wq Claudio
