On 21.7.2021. 18:41, Alexander Bluhm wrote:
> On Mon, Jul 19, 2021 at 07:33:55PM +0300, Vitaliy Makkoveev wrote:
>> Hi, pipex(4) is also not ready for parallel access. In the chunk below
>> it will be accessed through (*ifp->if_input)() -> ether_input() ->
>> pipex_pppoe_input(). This looks not fatal but makes at least session
>> statistics inconsistent.
> For pipex and pppoe we can put a kernel lock into ether_resolve().
> I also put locks in mpls.
>
> I am not aware of any other issues.
Hi,
i've applied this and ipsec crypto no queue diff and i'm getting
splasserts below ... maybe it's something obvious, if not, i will try
diff by diff ..
I'm running iked tunnel ...
log on box where traffic goes into tunnel
splassert: ipsp_process_done: want 2 have 0
Starting stack trace...
ipsp_process_done(fffffd80a8647400,ffff8000011832a0) at
ipsp_process_done+0x59
esp_output_cb(ffff8000011832a0,ffff800001194e00,fffffd80a8647400,21c,0)
at esp_output_cb+0x41
ipsec_output_cb(fffffd8397dad440) at ipsec_output_cb+0x177
taskq_thread(ffff80000013f480) at taskq_thread+0x81
end trace frame: 0x0, count: 253
End of stack trace.
splassert: ip_output: want 2 have 0
Starting stack trace...
ip_output(fffffd80a8647400,0,0,2,0,0) at ip_output+0x88
ipsp_process_done(fffffd80a8647400,ffff8000011832a0) at
ipsp_process_done+0x384
esp_output_cb(ffff8000011832a0,ffff800001194e00,fffffd80a8647400,21c,0)
at esp_o
utput_cb+0x41
ipsec_output_cb(fffffd8397dad440) at ipsec_output_cb+0x177
taskq_thread(ffff80000013f480) at taskq_thread+0x81
end trace frame: 0x0, count: 252
End of stack trace.
logs on box where traffic goes from tunnel out
splassert: tdb_hash: want 2 have 0
Starting stack trace...
tdb_hash(36b50c1c,ffff800001199200,32) at tdb_hash+0x5c
gettdb_dir(0,36b50c1c,ffff800001199200,32,0) at gettdb_dir+0x83
ipsec_input_cb(fffffd839e0c6ca0) at ipsec_input_cb+0x7a
taskq_thread(ffff800000140d80) at taskq_thread+0x81
end trace frame: 0x0, count: 253
End of stack trace.
splassert: esp_input_cb: want 2 have 0
Starting stack trace...
esp_input_cb(ffff80000118a5f8,ffff800001199200,fffffd80026f5500,0) at
esp_input_cb+0x73
ipsec_input_cb(fffffd839e0c6ca0) at ipsec_input_cb+0x162
taskq_thread(ffff800000140d80) at taskq_thread+0x81
end trace frame: 0x0, count: 254
End of stack trace.
splassert: enc_getif: want 2 have 0
Starting stack trace...
enc_getif(0,0) at enc_getif+0x54
ipsec_common_input_cb(fffffd80026f5500,ffff80000118a5f8,14,9) at
ipsec_common_input_cb+0x934
esp_input_cb(ffff80000118a5f8,ffff800001199200,fffffd80026f5500,0) at
esp_input_cb+0x456
ipsec_input_cb(fffffd839e0c6ca0) at ipsec_input_cb+0x162
taskq_thread(ffff800000140d80) at taskq_thread+0x81
end trace frame: 0x0, count: 252
End of stack trace.
