Vitaliy Makkoveev <m...@openbsd.org> writes:

> On Fri, Apr 30, 2021 at 10:14:31PM -0700, Greg Steuck wrote:
> Hi, you missing KERN_SYSVMSG, KERN_SYSVSEM, KERN_SYSVSHM variables. The
> rest diff is ok by me.

Good catch. My search/replace pattern wasn't good enough. Fixed and will
commit.

>> >> Unused, maybe introduce a single usage as an example?
>> >> 
>> >
>> > Or introduce this with the separate diff which will convert all related
>> > structures?
>> 
>> I failed to find a case where to use SYSCTL_INT_UNBOUNDED. We always
>> find better "common sense" limits than completely unconstrained.
>> 
>
> I guess it could be killed.

OK?

>From 157e54645ee8e0e36232db5be4f2ddce21a51d38 Mon Sep 17 00:00:00 2001
From: Greg Steuck <g...@lenny.nest.cx>
Date: Sat, 1 May 2021 09:03:07 -0700
Subject: [PATCH] Removed unused SYSCTL_INT_UNBOUNDED (no use planned)

Added a comment for SYSCTL_INT_READONLY.
---
 sys/sys/sysctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/sys/sysctl.h b/sys/sys/sysctl.h
index d574e2cb028..168c65ecf6d 100644
--- a/sys/sys/sysctl.h
+++ b/sys/sys/sysctl.h
@@ -1000,7 +1000,7 @@ struct sysctl_bounded_args {
        int maximum; /* read-only variable if minimum > maximum */
 };
 
-#define SYSCTL_INT_UNBOUNDED   0,0
+/* Special case minimum,maximum marker for sysctl_bounded_args. */
 #define SYSCTL_INT_READONLY    1,0
 
 /*
-- 
2.31.1

Reply via email to