On Mon, Apr 05, 2021 at 07:47:40AM +0000, Visa Hankala wrote:
> On Sun, Apr 04, 2021 at 11:56:57PM +0200, Klemens Nanni wrote:
> > ddb> show all mounts
> > mountpoint 0xffff8000000c8000
> > flags 4205800<WXALLOWED,LOCAL,ROOTFS,SOFTDEP>
> > vnodecovered 0x0 syncer 0xfffffd801f247a98 data 0xffff800000087800
> > vfsconf: ops 0xffffffff812ec530 name "ffs" num 1 ref 1 flags 0x201000
> > statvfs cache: bsize 800 iosize 4000
> > blocks 497095 free 84770 avail 59916
> > files 129598 ffiles 115439 favail 115439
> > f_fsidx {0x400, 0xe9b63a57} owner 0 ctime 0x606a341c
> > syncwrites 59 asyncwrites = 179
> > syncreads 13048 asyncreads = 0
> > fstype "ffs" mnton "/" mntfrom "/dev/sd0a" mntspec "5778912438e27f1e.a"
> > locked vnodes:
> >
> > From CVS history this looks like mickey simply overlooked SOFTDEP when
> > adding the "flags ..." output with
> >
> > sys/sys/mount.h revision 1.75
> > sys/kern/vfs_subr.c revision 1.133
> > date: 2006/07/11 21:17:58; author: mickey; state: Exp; lines: +126
> > -1;
> > add mount/vnode/buf and softdep printing commands; tested on a few
> > archs and will make pedro happy too (;
> >
> >
> > Use tabs not spaces while here (nicely pulling the relevant bits into
> > diff context).
> >
> > Feedback? OK?
>
> Shouldn't all the MNT_* bits be listed in the decoding directive?
> The directive is still incomplete.
Here's adding all bits.
Feedback? OK?
Index: mount.h
===================================================================
RCS file: /cvs/src/sys/sys/mount.h,v
retrieving revision 1.147
diff -u -p -r1.147 mount.h
--- mount.h 18 Jan 2020 08:40:19 -0000 1.147
+++ mount.h 5 Apr 2021 15:53:20 -0000
@@ -387,7 +387,9 @@ struct mount {
#define MNT_BITS \
"\20\001RDONLY\002SYNCHRONOUS\003NOEXEC\004NOSUID\005NODEV\006NOPERM" \
"\007ASYNC\010EXRDONLY\011EXPORTED\012DEFEXPORTED\013EXPORTANON" \
- "\014WXALLOWED\015LOCAL\016QUOTA\017ROOTFS\020NOATIME"
+ "\014WXALLOWED\015LOCAL\016QUOTA\017ROOTFS\020NOATIME\021UPDATE" \
+ "\022DELEXPORT\023RELOAD\024FORCE\025STALLED\026SWAPPABLE\032WANTRDWR" \
+ "\033SOFTDEP\034DOOMED"
/*
* filesystem control flags.
