> On 11 Mar 2021, at 8:06 pm, Klemens Nanni <k...@openbsd.org> wrote:
> 
> On Thu, Mar 11, 2021 at 01:46:34PM +1000, David Gwynne wrote:
> 
>>> +.It Cm link0
>>> +Disable the filtering of 802.1Q VLAN and QinQ SVLAN packets.
>>> +.It Cm -link0
>>> +Enable the filtering of 802.1Q VLAN and QinQ SVLAN packets.
>>> +Packets will appear to enter or leave the member port interfaces.
>> 
>> I dont think this line above should be here.
> I removed this line, but it is also present in TPMR from which I copied
> it?  Should it stay there?

I don't think so. Free commit!

> 
>>> +This is the default.
>>> +.It Cm link1
>>> +Enable the filtering of IPv4 and IPv6 packets with
>>> +.Xr pf 4 .
>>> +.It Cm -link1
>>> +Disable the filtering of IPv4 and IPv6 packets with
>>> +.Xr pf 4 .
>>> +This is the default.
>> 
>> Is it worth noting that vport(4) members of a veb(4) are different to other 
>> ports? The answer to this question doesnt affect my ok, the diff should go 
>> in and we can tweak this later.
> I'll leave that to a separate diff.

Cool.

Reply via email to