On Thu, Feb 25, 2021 at 11:29:09AM +0100, Karel Gardas wrote: > On 2/25/21 10:34 AM, Jonathan Gray wrote: > > On Wed, Feb 24, 2021 at 05:01:50PM +0100, Karel Gardas wrote: > > > Hello, > > > > > > attach patch adds some SkyLake-E related PCI ids. Tested on > > > Kontron/Fujitsu > > > D3598-B with Intel Xeon W-2123. > > > > > > Thanks for review, comment(s) and/or commit. > > > > > > Karel > > > > > I can only find a handful of Ubox/PCU numbers in > > > > '614073-336062-Xeon Scalable Mem Datasheet Vol2 R4.pdf' > > Intel Xeon Processor Scalable Family > > Datasheet, Volume Two: Registers > > August 2020 > > 336062-004US > > Thanks for the document reference. But I've used... > > > Is there a document that has most of these? > > FreeBSD's own pci vendor DB which claims to use data from PCI ID project: > > https://raw.githubusercontent.com/freebsd/freebsd-src/main/share/misc/pci_vendors > > > Can you send a dmesg without this diff applied? > > I hope you don't mind dmesg from current but from Dec 8 2020. Dmesg is from > W-2265 which shows a bit more > registers than W-2123. See below. > > > It is 'Skylake' not 'Sky Lake' and the descriptions are too verbose > > compared to existing pcidevs entries. > > If it is not 'Sky Lake' then it is in kind of format violation with > OpenBSD's own 'Apollo Lake' and 'Gemini Lake'.
'Products formerly Skylake' https://ark.intel.com/content/www/us/en/ark/products/codename/37572/skylake.html 'Products formerly Apollo Lake' https://ark.intel.com/content/www/us/en/ark/products/codename/80644/apollo-lake.html > So I would rather stay with 'Sky Lake-E'. As per verbosity I guess you are > most against 'Integrated Memory Controller' and against > various '.... Registers'. I may shorten and remove those... The marketing name is 'Xeon Processor Scalable Family' Intel Xeon Bronze 3XXX processor Intel Xeon Gold 6XXF processor Intel Xeon Platinum 6XXF processor Intel Xeon Platinum 8XXF processor Intel Xeon Silver 4XXX processor Intel Xeon Gold 5XXX processor Intel Xeon Platinum 6XXX processor Intel Xeon Platinum 8XXX processor Intel Xeon processor E Family Intel Xeon processor W Family Intel Core X-Series Processor Family i7 78xx and i9-79xx Series With there also being '2nd Generation Intel Xeon Scalable Processors' and '3rd Generation Intel Xeon Scalable Processors'. Intel documents contain statements like "The new Intel Xeon W processors are based on the Intel Xeon Scalable processor". So I think it should be 'SP' and 'SP 2G' much like the way 'E5' is used. > > Thanks, > Karel Going to the fujitsu page for D3598-B1 leads to FTS_ChipsetSoftwareInstallationUtility_101144PV_1184194.zip and inside that eventually is Skylake-ESystem.inf and KabyLakePCH-HSystem.inf PCI\VEN_8086&DEV_A2D3Desc="Intel(R) 200 Series Chipset Family LPC Controller (C422) - A2D3" PCI\VEN_8086&DEV_2014Desc="Intel(R) Xeon(R) processor P family/Core i7 Ubox Registers - 2014" PCI\VEN_8086&DEV_2015Desc="Intel(R) Xeon(R) processor P family/Core i7 Ubox Registers - 2015" PCI\VEN_8086&DEV_2016Desc="Intel(R) Xeon(R) processor P family/Core i7 Ubox Registers - 2016" PCI\VEN_8086&DEV_2018Desc="Intel(R) Xeon(R) processor P family/Core i7 M2PCI Registers - 2018" PCI\VEN_8086&DEV_2020Desc="Intel(R) Xeon(R) processor P family/Core i7 DMI3 Port - 2020" PCI\VEN_8086&DEV_2021Desc="Intel(R) Xeon(R) processor P family/Core i7 CBDMA Registers - 2021" PCI\VEN_8086&DEV_2024Desc="Intel(R) Xeon(R) processor P family/Core i7 MM/Vt - d Configuration Registers - 2024" PCI\VEN_8086&DEV_2025Desc="Intel(R) Xeon(R) processor P family/Core i7 RAS - 2025" PCI\VEN_8086&DEV_2026Desc="Intel(R) Xeon(R) processor P family/Core i7 IOAPIC - 2026" PCI\VEN_8086&DEV_2030Desc="Intel(R) Xeon(R) processor P family/Core i7 PCI Express Root Port 1A - 2030" PCI\VEN_8086&DEV_2031Desc="Intel(R) Xeon(R) processor P family/Core i7 PCI Express Root Port 1B - 2031" PCI\VEN_8086&DEV_2032Desc="Intel(R) Xeon(R) processor P family/Core i7 PCI Express Root Port 1C - 2032" PCI\VEN_8086&DEV_2033Desc="Intel(R) Xeon(R) processor P family/Core i7 PCI Express Root Port 1D - 2033" PCI\VEN_8086&DEV_2034Desc="Intel(R) Xeon(R) processor P family/Core i7 Intel VT - D - 2034" PCI\VEN_8086&DEV_2035Desc="Intel(R) Xeon(R) processor P family/Core i7 RAS Configuration Registers - 2035" PCI\VEN_8086&DEV_2036Desc="Intel(R) Xeon(R) processor P family/Core i7 IOxAPIC Configuration Registers - 2036" PCI\VEN_8086&DEV_2040Desc="Intel(R) Xeon(R) processor P family/Core i7 Integrated Memory Controller - 2040" PCI\VEN_8086&DEV_2041Desc="Intel(R) Xeon(R) processor P family/Core i7 Integrated Memory Controller - 2041" PCI\VEN_8086&DEV_2042Desc="Intel(R) Xeon(R) processor P family/Core i7 Integrated Memory Controller - 2042" PCI\VEN_8086&DEV_2043Desc="Intel(R) Xeon(R) processor P family/Core i7 Integrated Memory Controller - 2043" PCI\VEN_8086&DEV_2044Desc="Intel(R) Xeon(R) processor P family/Core i7 Integrated Memory Controller - 2044" PCI\VEN_8086&DEV_2045Desc="Intel(R) Xeon(R) processor P family/Core i7 LM Channel 1 - 2045" PCI\VEN_8086&DEV_2046Desc="Intel(R) Xeon(R) processor P family/Core i7 LMS Channel 1 - 2046" PCI\VEN_8086&DEV_2047Desc="Intel(R) Xeon(R) processor P family/Core i7 LMDP Channel 1 - 2047" PCI\VEN_8086&DEV_2048Desc="Intel(R) Xeon(R) processor P family/Core i7 DECS Channel 2 - 2048" PCI\VEN_8086&DEV_2049Desc="Intel(R) Xeon(R) processor P family/Core i7 LM Channel 2 - 2049" PCI\VEN_8086&DEV_204ADesc="Intel(R) Xeon(R) processor P family/Core i7 LMS Channel 2 - 204A" PCI\VEN_8086&DEV_204BDesc="Intel(R) Xeon(R) processor P family/Core i7 LMDP Channel 2 - 204B" PCI\VEN_8086&DEV_204CDesc="Intel(R) Xeon(R) processor P family/Core i7 M3KTI Registers - 204C" PCI\VEN_8086&DEV_204DDesc="Intel(R) Xeon(R) processor P family/Core i7 M3KTI Registers - 204D" PCI\VEN_8086&DEV_204EDesc="Intel(R) Xeon(R) processor P family/Core i7 M3KTI Registers - 204E" PCI\VEN_8086&DEV_2054Desc="Intel(R) Xeon(R) processor P family/Core i7 CHA Registers - 2054" PCI\VEN_8086&DEV_2055Desc="Intel(R) Xeon(R) processor P family/Core i7 CHA Registers - 2055" PCI\VEN_8086&DEV_2056Desc="Intel(R) Xeon(R) processor P family/Core i7 CHA Registers - 2056" PCI\VEN_8086&DEV_2057Desc="Intel(R) Xeon(R) processor P family/Core i7 CHA Registers - 2057" PCI\VEN_8086&DEV_2058Desc="Intel(R) Xeon(R) processor P family/Core i7 KTI 0 - 2058" PCI\VEN_8086&DEV_2059Desc="Intel(R) Xeon(R) processor P family/Core i7 UPI Registers - 2059" PCI\VEN_8086&DEV_2066Desc="Intel(R) Xeon(R) processor P family/Core i7 Integrated Memory Controller - 2066" PCI\VEN_8086&DEV_2068Desc="Intel(R) Xeon(R) processor P family/Core i7 DDRIO Registers - 2068" PCI\VEN_8086&DEV_2069Desc="Intel(R) Xeon(R) processor P family/Core i7 DDRIO Registers - 2069" PCI\VEN_8086&DEV_206ADesc="Intel(R) Xeon(R) processor P family/Core i7 DDRIO Registers - 206A" PCI\VEN_8086&DEV_206BDesc="Intel(R) Xeon(R) processor P family/Core i7 DDRIO Registers - 206B" PCI\VEN_8086&DEV_206CDesc="Intel(R) Xeon(R) processor P family/Core i7 DDRIO Registers - 206C" PCI\VEN_8086&DEV_206DDesc="Intel(R) Xeon(R) processor P family/Core i7 DDRIO Registers - 206D" PCI\VEN_8086&DEV_206EDesc="Intel(R) Xeon(R) processor P family/Core i7 DDRIO Registers - 206E" PCI\VEN_8086&DEV_2080Desc="Intel(R) Xeon(R) processor P family/Core i7 PCU Registers - 2080" PCI\VEN_8086&DEV_2081Desc="Intel(R) Xeon(R) processor P family/Core i7 PCU Registers - 2081" PCI\VEN_8086&DEV_2082Desc="Intel(R) Xeon(R) processor P family/Core i7 PCU Registers - 2082" PCI\VEN_8086&DEV_2083Desc="Intel(R) Xeon(R) processor P family/Core i7 PCU Registers - 2083" PCI\VEN_8086&DEV_2084Desc="Intel(R) Xeon(R) processor P family/Core i7 PCU Registers - 2084" PCI\VEN_8086&DEV_2085Desc="Intel(R) Xeon(R) processor P family/Core i7 PCU Registers - 2085" PCI\VEN_8086&DEV_2086Desc="Intel(R) Xeon(R) processor P family/Core i7 PCU Registers - 2086" PCI\VEN_8086&DEV_208DDesc="Intel(R) Xeon(R) processor P family/Core i7 CHA Registers - 208D" PCI\VEN_8086&DEV_208EDesc="Intel(R) Xeon(R) processor P family/Core i7 CHA Registers - 208E" Index: pcidevs =================================================================== RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1956 diff -u -p -r1.1956 pcidevs --- pcidevs 22 Feb 2021 01:17:23 -0000 1.1956 +++ pcidevs 25 Feb 2021 13:16:58 -0000 @@ -4188,6 +4188,61 @@ product INTEL ATOMC2000_PCU_SMB 0x1f3c A product INTEL I354_BP_1GBPS 0x1f40 I354 product INTEL I354_SGMII 0x1f41 I354 SGMII product INTEL I354_BP_2_5GBPS 0x1f45 I354 +product INTEL SP_UBOX_1 0x2014 SP Ubox +product INTEL SP_UBOX_2 0x2015 SP Ubox +product INTEL SP_UBOX_3 0x2016 SP Ubox +product INTEL SP_M2PCI 0x2018 SP M2PCI +product INTEL SP_HB 0x2020 SP Host +product INTEL SP_CBDMA 0x2021 SP CBDMA +product INTEL SP_VTD_1 0x2024 SP VT-d +product INTEL SP_RAS_1 0x2025 SP RAS +product INTEL SP_IOAPIC 0x2026 SP I/O APIC +product INTEL SP_PCIE_1 0x2030 SP PCIE +product INTEL SP_PCIE_2 0x2031 SP PCIE +product INTEL SP_PCIE_3 0x2032 SP PCIE +product INTEL SP_PCIE_4 0x2033 SP PCIE +product INTEL SP_VTD_2 0x2034 SP VT-d +product INTEL SP_RAS_2 0x2035 SP RAS +product INTEL SP_IOXAPIC 0x2036 SP IOxAPIC +product INTEL SP_IMC_1 0x2040 SP IMC +product INTEL SP_IMC_2 0x2041 SP IMC +product INTEL SP_IMC_3 0x2042 SP IMC +product INTEL SP_IMC_4 0x2043 SP IMC +product INTEL SP_IMC_5 0x2044 SP IMC +product INTEL SP_LM_C1 0x2045 SP LM +product INTEL SP_LMS_C1 0x2046 SP LMS +product INTEL SP_LMDP_C1 0x2047 SP LMDP +product INTEL SP_DECS_C2 0x2048 SP DECS +product INTEL SP_LM_C2 0x2049 SP LM +product INTEL SP_LMS_C2 0x204a SP LMS +product INTEL SP_LMDP_C2 0x204b SP LMDP +product INTEL SP_M3KTI_1 0x204c SP M3KTI +product INTEL SP_M3KTI_2 0x204d SP M3KTI +product INTEL SP_M3KTI_3 0x204e SP M3KTI +product INTEL SP_CHA_1 0x2054 SP CHA +product INTEL SP_CHA_2 0x2055 SP CHA +product INTEL SP_CHA_3 0x2056 SP CHA +product INTEL SP_CHA_4 0x2057 SP CHA +product INTEL SP_KTI 0x2058 SP KTI +product INTEL SP_UPI 0x2059 SP UPI +product INTEL SP_IMC 0x2066 SP IMC +product INTEL SP_DDRIO_1 0x2068 SP DDRIO +product INTEL SP_DDRIO_2 0x2069 SP DDRIO +product INTEL SP_DDRIO_3 0x206a SP DDRIO +product INTEL SP_DDRIO_4 0x206b SP DDRIO +product INTEL SP_DDRIO_5 0x206c SP DDRIO +product INTEL SP_DDRIO_6 0x206d SP DDRIO +product INTEL SP_DDRIO_7 0x206e SP DDRIO +product INTEL SP_PCU_1 0x2080 SP PCU +product INTEL SP_PCU_2 0x2081 SP PCU +product INTEL SP_PCU_3 0x2082 SP PCU +product INTEL SP_PCU_4 0x2083 SP PCU +product INTEL SP_PCU_5 0x2084 SP PCU +product INTEL SP_PCU_6 0x2085 SP PCU +product INTEL SP_PCU_7 0x2086 SP PCU +product INTEL SP_M2PCIE 0x2088 SP M2PCIe +product INTEL SP_CHA_5 0x208d SP CHA +product INTEL SP_CHA_6 0x208e SP CHA product INTEL BSW_HB 0x2280 Braswell Host product INTEL BSW_HDA 0x2284 Braswell HD Audio product INTEL BSW_SIO_DMA_2 0x2286 Braswell SIO DMA @@ -5622,6 +5677,11 @@ product INTEL C610_MS_SPSR 0x8d7c C610 M product INTEL C610_MS_SMB_1 0x8d7d C610 MS SMBus product INTEL C610_MS_SMB_2 0x8d7e C610 MS SMBus product INTEL C610_MS_SMB_3 0x8d7f C610 MS SMBus +product INTEL I2OPCIB 0x9620 I2O RAID +product INTEL RCU21 0x9621 RCU21 I2O RAID +product INTEL RCUXX 0x9622 RCUxx I2O RAID +product INTEL RCU31 0x9641 RCU31 I2O RAID +product INTEL RCU31L 0x96a1 RCU31L I2O RAID product INTEL TGL_UP4_2C_HB 0x9a02 Core 11G Host product INTEL TGL_DTT 0x9a03 Core 11G DTT product INTEL TGL_UP3_2C_HB 0x9a04 Core 11G Host @@ -5641,11 +5701,6 @@ product INTEL TGL_PCIE_3 0x9a25 Core 11G product INTEL TGL_PCIE_4 0x9a27 Core 11G PCIE product INTEL TGL_PCIE_5 0x9a29 Core 11G PCIE product INTEL TGL_NPK 0x9a33 Core 11G NPK -product INTEL I2OPCIB 0x9620 I2O RAID -product INTEL RCU21 0x9621 RCU21 I2O RAID -product INTEL RCUXX 0x9622 RCUxx I2O RAID -product INTEL RCU31 0x9641 RCU31 I2O RAID -product INTEL RCU31L 0x96a1 RCU31L I2O RAID product INTEL TGL_GT2_1 0x9a40 Xe Graphics product INTEL TGL_GT2_2 0x9a49 Xe Graphics product INTEL TGL_GT2_3 0x9a59 Graphics @@ -5679,8 +5734,8 @@ product INTEL CML_U_GT1_3 0x9bac UHD Gra product INTEL CML_GT2_4 0x9bc2 UHD Graphics product INTEL CML_GT2_3 0x9bc4 UHD Graphics product INTEL CML_GT2_1 0x9bc5 UHD Graphics 630 -product INTEL CML_GT2_2 0x9bc8 UHD Graphics 630 product INTEL CML_GT2_5 0x9bc6 UHD Graphics P630 +product INTEL CML_GT2_2 0x9bc8 UHD Graphics 630 product INTEL CML_U_GT2_2 0x9bca UHD Graphics product INTEL CML_U_GT2_3 0x9bcc UHD Graphics product INTEL CML_GT2_6 0x9be6 UHD Graphics P630 @@ -6001,6 +6056,7 @@ product INTEL Q250_LPC 0xa2c7 Q250 LPC product INTEL B250_LPC 0xa2c8 B250 LPC product INTEL Z370_LPC 0xa2c9 Z370 LPC product INTEL X299_LPC 0xa2d2 X299 LPC +product INTEL C422_LPC 0xa2d3 C422 LPC product INTEL 200SERIES_I2C_1 0xa2e0 200 Series I2C product INTEL 200SERIES_I2C_2 0xa2e1 200 Series I2C product INTEL 200SERIES_I2C_3 0xa2e2 200 Series I2C
