On Mon, Jan 18, 2021 at 05:31:21PM +0100, Florian Obser wrote: > This is my take on -fno-common fixes. > > slaacd, unwind and rad are based on the same template so the fixes > were similar > > - remove global $daemon_process, just use a const string for > setproctitle > - move ctl_conns to control.c and control_state to frontend.c, > control_state needs to be extern because it's shared between > frontend.c and control.c. (I see that claudio fixed this differently > in ospfd)
It is pretty similar, the only change is that I also removed control_state from the frontend code and just pass the fd to control_listen(). This way the full control_state becomes internal. > - give imsgevs unique names by using proc1_to_proc2 variable names > - other fixes unique per daemon I glanced over this and it looks ok. -- :wq Claudio
