On Wed, Jan 06, 2021 at 10:24:47AM +0100, Florian Obser wrote: > On Wed, Jan 06, 2021 at 10:11:01AM +0100, Anton Lindqvist wrote: > > Hi, > > I have a unbound forward zone configured on my router for my $DAYJOB. > > The address associated with the zone is only accessible when the router > > is connected to a VPN. If the VPN connection is absent, trying to > > resolve any domain that must be handled by the zone crashes unbound. > > Turns out there's a missing NULL check in comm_point_send_udp_msg(). > > The same routine already has `if (addr) {} else {}' branches so I guess > > protecting the call to log_addr() using the same conditional is > > reasonable. > > > > Should this instead be upstreamed? Comments? OK? > > yes, please upstream it.
Pending pull request submitted: https://github.com/NLnetLabs/unbound/pull/395 > Could you also do sbin/unwind/libunbound/util/netevent.c? Sure, done.