On Sat, Oct 24, 2020 at 09:46:35AM +0000, Varik Valefor wrote: > Sir or Madam: > > Some additional grammatical fixes should be attached to this message. >
hi. i'm afraid most of these are just not fixes. my advice is to send small, similarly grouped diffs, until you get a feel for what kind of fixes might get accepted. that would also make it easier to give you feedback on individual questions. from your diff i committed the diff below, and have rejected everything else. i may have missed something, but the diff was so large it was difficult to read. thanks, jmc Index: lib/libskey/skey.5 =================================================================== RCS file: /cvs/src/lib/libskey/skey.5,v retrieving revision 1.8 diff -u -p -r1.8 skey.5 --- lib/libskey/skey.5 25 Jan 2019 00:19:26 -0000 1.8 +++ lib/libskey/skey.5 24 Oct 2020 10:30:26 -0000 @@ -31,7 +31,7 @@ directory contains user records for the system. .Pp Records take the form of files within -.Pa /etc/skey +.Pa /etc/skey , where each file is named for the user whose record it contains. For example, .Pa /etc/skey/root @@ -51,7 +51,7 @@ Each record consists of five lines: The name of the user the record describes. This should be the same as the name of the file. .It -The hash type used for this entry; +The hash type used for this entry: one of md5, sha1, or rmd160. The default is md5. .It @@ -62,7 +62,7 @@ Each time the user authenticates via S/K A seed used along with the sequence number and the six S/Key words to compute the value. .It -The value expected from the crunching of the user's seed, sequence number +The value expected from the crunching of the user's seed, sequence number, and the six S/Key words. When the result matches this value, authentication is considered to have been successful. Index: lib/libusbhid/usbhid.3 =================================================================== RCS file: /cvs/src/lib/libusbhid/usbhid.3,v retrieving revision 1.20 diff -u -p -r1.20 usbhid.3 --- lib/libusbhid/usbhid.3 12 May 2020 13:03:52 -0000 1.20 +++ lib/libusbhid/usbhid.3 24 Oct 2020 10:30:26 -0000 @@ -86,7 +86,7 @@ The .Nm library provides routines to extract data from USB Human Interface Devices. .Ss INTRODUCTION -USB HID devices send and receive data laid out in a device dependent way. +USB HIDs send and receive data laid out in a device dependent way. The .Nm library contains routines to extract the @@ -117,10 +117,10 @@ return .Fa NULL on failure. .Ss DESCRIPTOR PARSING FUNCTIONS -To parse the report descriptor the +To parse the report descriptor, the .Fn hid_start_parse function should be called with a report descriptor and a set that -describes which items that are interesting. +describes which items are interesting. The set is obtained by or-ing together values .Fa (1 << k) where @@ -198,8 +198,8 @@ A return value of \-1 indicates that an .Va errno is set. .Ss DATA EXTRACTION FUNCTIONS -Given the data obtained from a HID device and an item in the -report descriptor the +Given the data obtained from a HID and an item in the +report descriptor, the .Fn hid_get_data function extracts the value of the item. Conversely
