On Thu, Apr 23, 2020 at 07:31:37PM +0100, Ricardo Mestre wrote: > Hi, > > This one looks like a typo and might cause a double free. > > CID 1492713 > > OK?
ok jmatthew@ > > Index: if_mcx.c > =================================================================== > RCS file: /cvs/src/sys/dev/pci/if_mcx.c,v > retrieving revision 1.43 > diff -u -p -u -r1.43 if_mcx.c > --- if_mcx.c 21 Apr 2020 05:49:25 -0000 1.43 > +++ if_mcx.c 23 Apr 2020 18:27:34 -0000 > @@ -6023,7 +6023,7 @@ mcx_up(struct mcx_softc *sc) > return ENETRESET; > destroy_tx_slots: > mcx_free_slots(sc, sc->sc_tx_slots, i, (1 << MCX_LOG_SQ_SIZE)); > - sc->sc_rx_slots = NULL; > + sc->sc_tx_slots = NULL; > > i = (1 << MCX_LOG_RQ_SIZE); > destroy_rx_slots:
