On Fri, Mar 06 2020, Sebastian Benoit <be...@openbsd.org> wrote: > Job Snijders(j...@openbsd.org) on 2020.03.06 17:31:13 +0000: >> I have a small suggestion, in some deployments I saw the convention to >> name it as following so it is clear the data came from user provided >> data rather than internal bird structures >> >> I tested Benno's patch against BIRD 1.6.6 - wfm. > > thanks. > > I did not commit this bit, and i have not substantiated opinion on it. > If thats how bird users do it, commit it ;)
I guess the manpage needs an update (-T tablename). >> >> Index: main.c >> =================================================================== >> RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v >> retrieving revision 1.58 >> diff -u -p -r1.58 main.c >> --- main.c 11 Feb 2020 18:41:39 -0000 1.58 >> +++ main.c 6 Mar 2020 17:25:56 -0000 >> @@ -156,7 +156,7 @@ static void build_chain(const struct aut >> static void build_crls(const struct auth *, struct crl_tree *, >> STACK_OF(X509_CRL) **); >> >> -const char *bird_tablename = "roa"; >> +const char *bird_tablename = "ROAS"; >> >> int verbose; >> >> > -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
