Re: [patch] use acme-client to sign certificated with ecdsa keys

[Renaud Allard]

On 6/14/19 1:58 PM, Florian Obser wrote:

On Fri, Jun 14, 2019 at 09:50:35AM +0200, Renaud Allard wrote:

On 6/12/19 2:30 PM, Renaud Allard wrote:

On 6/11/19 2:36 PM, Sebastian Benoit wrote:

Hi,

some feedback below.

Renaud: maybe wait for feedback from florian or gilles until
acting on my comments, sometimes sending diffs to fast creates more
work ;)

/Benno

As suggested by benno@
removal of the global variable
removal of KEYTYPE which was not used and was a leftover of a former patch
define ECDSA_KEY to be more readable

Any comment or OK on my latest patch?

I'd prefer to use enums like the rest of the code.

Indeed, that seems even more explicit. I can't say an official OK, but that's OK to me :)

smime.p7s
Description: S/MIME Cryptographic Signature