On Sat, Apr 27 2019, Nathanael Rensen <nathan...@list.polymorpheus.com> wrote: > The diff below speeds up ld.so library intialisation where the dependency > tree is broad and deep, such as samba's smbd which links over 100 libraries. > > See for example https://marc.info/?l=openbsd-misc&m=155007285712913&w=2 > > See https://marc.info/?l=openbsd-tech&m=155637285221396&w=2 for part 1 > that speeds up library loading. > > The timings below are for /usr/local/sbin/smbd --version: > > Timing without either diff : 6m45.67s real 6m45.65s user 0m00.02s system > Timing with part 1 diff only: 4m42.88s real 4m42.85s user 0m00.02s system > Timing with part 2 diff only: 2m02.61s real 2m02.60s user 0m00.01s system > Timing with both diffs : 0m00.03s real 0m00.03s user 0m00.00s system
First off, thanks a lot for solving this long outstanding issue. The use of ld --as-needed hides the problem but it looks like ld.lld isn't as good as ld.bfd at eliminating extra inter-library references. As I told mpi@ earlier today, I think your changes are correct as is, and are good to be committed. So this counts as an ok jca@. But I'd expect other developers to chime in soon, maybe they'll spot something that I didn't. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
