Alexander Bluhm wrote: > Hi, > > when there is an invalid character in the uuencoded stream, uudecode(1) > prints this error message: > > uudecode: in: out: character out of range: [33-96] > > Problem is that you don't know what is wrong. So I would like to > print the invalid character. As printing invalid input to the > terminal is a bad idea, I use the ascii code in decimal. > > uudecode: in: out: character 10 in decimal out of range: [33-96]
The first time I read this I thought it was the character position. Would "character value (%d) out of range" be clearer? Either way, printing something seems like an improvement. So ok. Also, I think you should add an (unsigned char) cast, otherwise bytes with the high bit may print as negative, which is probably confusing.
