On 2018/04/24 17:15, Landry Breuil wrote: > On Tue, Apr 24, 2018 at 04:04:34PM +0100, Stuart Henderson wrote: > > On 2018/04/24 16:34, Landry Breuil wrote: > > > Hi, > > > > > > here's a diff to reuse usbd_devinfo_vp() (exposed in usbdivar.h) in > > > VIDIOC_QUERYCAP ioctl callback, this way we can fill v4l2_capability > > > card struct member with the actual usb product name instead of a dummy > > > "Generic USB video class device". > > > > Generally I think this is a good idea, but some devices have crap in > > v/p, is that likely to cause any problems? > > Well, the exact same function is called in usbd_devinfo() during boot to > generate the dmesg lines for the devices.. so i dont really see how it makes > things worse. > > uvideo0 at uhub1 port 1 configuration 1 interface 0 "Logitech QuickCam Orbit > AF" rev 2.00/0.08 addr 3 > uvideo1 at uhub1 port 8 configuration 1 interface 0 "Chicony Electronics > Co.,Ltd. Integrated Camera" rev 2.00/0.29 addr 5 > > Landry >
I've looked through dmesglog for strings in uvideo lines and they all look pretty sane. I'm surprised, I've seen random-looking binary stuff on some devices and was unsure how programs might handle that.
