On Fri, 28 Jul 2017 12:36:22 +0000 Florian Obser <flor...@openbsd.org> wrote:
> not really a problem, errstr are just various static strings, but still...
>
> pointed out by clang, OK?
>
> diff --git snmpd/parse.y snmpd/parse.y
> index efd1159c3ab..cc3d4194556 100644
> --- snmpd/parse.y
> +++ snmpd/parse.y
> @@ -273,14 +273,14 @@ main : LISTEN ON STRING {
> const char *errstr;
> user = usm_newuser($2, &errstr);
> if (user == NULL) {
> - yyerror(errstr);
> + yyerror("%s", errstr);
> free($2);
> YYERROR;
> }
> } userspecs {
> const char *errstr;
> if (usm_checkuser(user, &errstr) < 0) {
> - yyerror(errstr);
> + yyerror("%s", errstr);
> YYERROR;
> }
> user = NULL;
>
>
Definitely an improvement! ok gerhard@
