Hi Mike,
Mike Belopuhov wrote on Fri, Jul 21, 2017 at 07:08:06PM +0200:
> Thanks for the detailed respose, I share your outlook and in
> this case it is better to keep this stuff in the userland since
> we actually can do it just fine.
Fair enough!
> I will however add some text to the
> hostctl(8) man page to highlight the fact that multiple pvbus
> devices may be present on a single VM.
Makes sense to me.
> OK?
Reads well to me.
Optionally, consider the two following nits:
1. It might make sense to mention in half a sentence why it is
useful to set these properties, probably up front like in
When running under XenServer, to let the host know that the guest
has finished initializing and to allow graceful restarts (or
whatever), set the following XenStore properties with
.Xr hostctl 8
in
.Xr rc.local 8 :
or (less convincing to me) after your existing text like so:
Without these settings, graceful restarts (or whatever)
may not work.
In any case, you want "in rc.local", not "in the rc.local".
2. Magic number alarm:
# XenServer Tools version
hostctl attr/PVAddons/MajorVersion 6
hostctl attr/PVAddons/MinorVersion 2
hostctl attr/PVAddons/MicroVersion 0
hostctl attr/PVAddons/BuildVersion 76888
hostctl attr/PVAddons/Installed 1
With the changed content, this reads a bit like a HOWTO:
Type these commands, but i won't tell you what they do.
If these numbers are completely fake and irrelevant,
then saying so in one short sentence - or even in the
comment line above - may be sufficient.
But this quote from Maxim fuels doubts:
:: I don't know whether XenServer actually cares about what
:: version is reported, but if it does, this would be tied
:: to features supported by xen, xbf, and xnf drivers.
:: You typically update the tools with each new XenServer
:: release, which gives you most recent disk and
:: network drivers, at least on Windows.
If that is true, than you have just built a time bomb:
YOU need to remember to regularly update the manual.
USERS need to remember to regularly update their rc.local.
If the latter is true, this may need to be explained
in this manual page. Of course, that can be figured
out and improved later, if needed. Including a change
to explain where to get the right magic numbers from
rather than simply advertising some numbers that may be
good today, but not tomorrow.
Yours,
Ingo
