"Todd C. Miller" <todd.mil...@courtesan.com> writes: > On Fri, 14 Jul 2017 22:15:49 +0200, Jeremie Courreges-Anglas wrote: > >> the proposal in >> >> https://marc.info/?l=openbsd-misc&m=150001966325010&w=2 >> >> made me look at newsyslog and its manually linked lists. Here's a stab >> at using TAILQs instead. > > Oh good, now I don't have to do it ;-)
;) > I have a diff to make change errx() into warnx() + continue. I have a similar diff which is a bit intrusive, as it tries to properly free resources allocated in parse_file(). Maybe show us yours first? >> Notes: >> - no attempt is made to free unused entries. >> - "free(p)" below isn't enough to properly deallocate the memory used by >> an entry anyway. >> - when parsing the config file, we only add an entry to the list once we >> know it is "good". >> >> I find this more readable. ok? > > OK millert@ Committed, thanks. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
