Hi,
Some minor nits discovered while getting rid of TIOCSTI:
- Sort and split includes according to style(9)
- Get rid of unused stdarg.h
- Join defines
- Fix indent for COMMAND typedef
Comments? OK?
Index: file.c
===================================================================
RCS file: /cvs/src/bin/csh/file.c,v
retrieving revision 1.25
diff -u -p -r1.25 file.c
--- file.c 21 Jun 2017 18:55:15 -0000 1.25
+++ file.c 21 Jun 2017 19:09:45 -0000
@@ -30,19 +30,18 @@
* SUCH DAMAGE.
*/
-
-#include <sys/types.h>
#include <sys/ioctl.h>
#include <sys/stat.h>
-#include <termios.h>
+#include <sys/types.h>
+
#include <dirent.h>
#include <errno.h>
+#include <limits.h>
#include <pwd.h>
#include <stdlib.h>
#include <string.h>
+#include <termios.h>
#include <unistd.h>
-#include <limits.h>
-#include <stdarg.h>
#include "csh.h"
#include "extern.h"
@@ -61,13 +60,13 @@
#define FALSE 0
#endif
-#define ESC '\033'
-
+#define ESC '\033'
#define TABWIDTH 8
typedef enum {
- LIST, RECOGNIZE
-} COMMAND;
+ LIST,
+ RECOGNIZE
+} COMMAND;
struct cmdline {
int fdin;
