On 9 January 2017 at 16:10, Martin Pieuchot <m...@openbsd.org> wrote: > As reported by Hrvoje Popovski, these two callbacks also need the > NET_LOCK(): > > splassert: ip_output: want 1 have 0 > Starting stack trace... > ip_output() at ip_output+0x7d > pfsync_sendout() at pfsync_sendout+0x499 > pfsync_update_tdb() at pfsync_update_tdb+0x13a > esp_input_cb() at esp_input_cb+0x234 > taskq_thread() at taskq_thread+0x6c > end trace frame: 0x0, count: 252 > End of stack trace. > > ok? >
Yes, IPsec callbacks need the NET_LOCK.