On Sat, 10 Sep 2016, Martin Natano wrote: > When building with noperm the symlinks end up with the build user as > owner instead of root. Ok? ... > --- bin/chmod/Makefile 6 Sep 2001 18:52:55 -0000 1.7 > +++ bin/chmod/Makefile 10 Sep 2016 17:31:05 -0000 > @@ -10,9 +10,11 @@ LINKS= ${BINDIR}/chmod ${BINDIR}/chgrp \ > afterinstall: > (cd ${DESTDIR}/usr/sbin; \ > ln -sf ../../sbin/chown .; \ > - ln -sf ../../bin/chgrp .) > + ln -sf ../../bin/chgrp .; \ > + chown -h root:wheel chown chgrp) > (cd ${DESTDIR}/usr/bin; \ > - ln -sf ../../bin/chmod chflags) > + ln -sf ../../bin/chmod chflags; \ > + chown -h root:wheel chflags)
As with the sysctl symlink, I think these should be root:bin. Also, let's follow best practice and s/;/ &&/ in those commands so that failure propagates.