constify auth functions

[Ted Unangst]

I'm getting annoying warnings because these functions aren't const.


Index: include/bsd_auth.h
===================================================================
RCS file: /cvs/src/include/bsd_auth.h,v
retrieving revision 1.10
diff -u -p -r1.10 bsd_auth.h
--- include/bsd_auth.h  21 Apr 2014 11:27:34 -0000      1.10
+++ include/bsd_auth.h  1 Sep 2016 13:15:08 -0000
@@ -60,15 +60,15 @@ char        *auth_getitem(auth_session_t *, aut
 int     auth_setitem(auth_session_t *, auth_item_t, char *);
 
 auth_session_t *auth_open(void);
-auth_session_t *auth_verify(auth_session_t *, char *, char *, ...)
+auth_session_t *auth_verify(auth_session_t *, const char *, const char *, ...)
                    __attribute__((__sentinel__));
 
-auth_session_t *auth_userchallenge(char *, char *, char *, char **);
-auth_session_t *auth_usercheck(char *, char *, char *, char *);
+auth_session_t *auth_userchallenge(const char *, const char *, const char *, 
char **);
+auth_session_t *auth_usercheck(const char *, const char *, const char *, char 
*);
 
 int     auth_userresponse(auth_session_t *, char *, int);
-int     auth_userokay(char *, char *, char *, char *);
-int     auth_approval(auth_session_t *, struct login_cap *, char *, char *);
+int     auth_userokay(const char *, const char *, const char *, char *);
+int     auth_approval(auth_session_t *, struct login_cap *, const char *, 
const char *);
 
 int     auth_close(auth_session_t *);
 void    auth_clean(auth_session_t *);
Index: lib/libc/gen/authenticate.c
===================================================================
RCS file: /cvs/src/lib/libc/gen/authenticate.c,v
retrieving revision 1.26
diff -u -p -r1.26 authenticate.c
--- lib/libc/gen/authenticate.c 26 May 2016 15:51:37 -0000      1.26
+++ lib/libc/gen/authenticate.c 1 Sep 2016 13:12:42 -0000
@@ -174,7 +174,7 @@ auth_cat(char *file)
 DEF_WEAK(auth_cat);
 
 int
-auth_approval(auth_session_t *as, login_cap_t *lc, char *name, char *type)
+auth_approval(auth_session_t *as, login_cap_t *lc, const char *name, const 
char *type)
 {
        int close_on_exit, close_lc_on_exit, len;
        struct passwd pwstore, *pwd;
@@ -305,7 +305,7 @@ out:
 DEF_WEAK(auth_approval);
 
 auth_session_t *
-auth_usercheck(char *name, char *style, char *type, char *password)
+auth_usercheck(const char *name, const char *style, const char *type, char 
*password)
 {
        char namebuf[LOGIN_NAME_MAX + 1 + NAME_MAX + 1];
        char pwbuf[_PW_BUF_LEN];
@@ -363,7 +363,7 @@ auth_usercheck(char *name, char *style, 
 DEF_WEAK(auth_usercheck);
 
 int
-auth_userokay(char *name, char *style, char *type, char *password)
+auth_userokay(const char *name, const char *style, const char *type, char 
*password)
 {
        auth_session_t *as;
 
@@ -374,7 +374,7 @@ auth_userokay(char *name, char *style, c
 DEF_WEAK(auth_userokay);
 
 auth_session_t *
-auth_userchallenge(char *name, char *style, char *type, char **challengep)
+auth_userchallenge(const char *name, const char *style, const char *type, char 
**challengep)
 {
        char namebuf[LOGIN_NAME_MAX + 1 + NAME_MAX + 1];
        auth_session_t *as;
@@ -489,7 +489,7 @@ DEF_WEAK(auth_userresponse);
  * worked.
  */
 auth_session_t *
-auth_verify(auth_session_t *as, char *style, char *name, ...)
+auth_verify(auth_session_t *as, const char *style, const char *name, ...)
 {
        va_list ap;
        char path[PATH_MAX];