On Wed, Aug 03, 2016 at 02:56:53PM -0600, Theo de Raadt wrote: > Can the iir read be after the tty check, or must it be before? >
When I did that diff initially I had the read and busy check after the sc->sc_tty check. The hardware I created this diff for has a shared interrupt line for two uarts. So I opened one uart, and the other not-opened (but attached) uart flooded me. Then I moved the lines around, so that even though there is no console opened, the interrupt flood would be taken care of. The Allwinner, OMAP and Marvell hardware do not share a single line between the uarts. Thus this part of the diff is not needed. For the FreeScale LS1 hardware it might be a better fix to find a way to disable an un-opened uart completely, so that it does not even try throwing interrupts around. Then this part of the diff would also not be needed. Long story short, I guess I can keep it as it was before.
