On Sat, Jan 23, 2016 at 01:45:05AM -0500, Michael McConville wrote:
> Vadim Zhukov wrote:
> > 2016-01-22 23:18 GMT+03:00 Martijn van Duren
> > <openbsd+t...@list.imperialat.at>:
> > > 5) 5_vi_remove_v_strdup.diff: Use strdup instead of v_strdup.
> >
> > Not okay: MALLOC macro prints information message to user, while
> > patched version isn't. I think refactoring shouldn't have such visible
> > impact on functionality, to make sure nothing breaks.
>
> On the subject of the allocation macros:
>
> o maybe we should wrap them in do { ... } while (0) for safety's sake
>
> o I got the *_NOMSG removals upstreamed. Is the below diff ok? No
> binary change.
I already gave you my ok for this early December... I think it is still
ok, but maybe you could wait until martijn's diffs are reviewed and in?
This is enough of a mouthful already.
