David Gwynne [da...@gwynne.id.au] wrote:
> IFF_OACTIVE means the hardware ring is full, not if it is busy.
> 
> perhaps a better check is to see whether there are pending packets
> on the send queue?
> 
> i could also argue we dont need the check at all, but this is less
> of a semantic change.
> 
> ok?

Seems getting rid of this is a smaller semantic change than doing
the actual check that the comments imply here. If the original goal
was to provide some sort of early loop prevention, has it been
important enough that you'd rather now see an essentially new ioctl failure?

Reply via email to