Sevan Janiyan wrote: > > > On 21/07/2015 00:16, Sevan Janiyan wrote: > > Hi, > > Attached is a diff for a couple of issues raised by coverity, obtained > > from NetBSD src/bin/cat/cat.c r1.53 & r1.54 > > > >>From the commit message in NetBSD CVS: > > "bin/cat/cat.c 976654 Argument cannot be negative > > (missing check for fileno result, stdout) > > bin/cat/cat.c 976653 Improper use of negative value > > (missing check for fileno result, stdin)" > > > > Diff also adds a skip label used by the changes which appeared in NetBSD > > at a different revision in the past.
have you tested this? does it make a difference? when does fileno(stdin) return -1?
