On Mon, May 25, 2015 at 1:23 PM, sven falempin <sven.falem...@gmail.com> wrote: > Index: relay.c > =================================================================== > RCS file: /cvs/src/usr.sbin/relayd/relay.c,v > retrieving revision 1.194 > diff -u -p -r1.194 relay.c > --- relay.c 18 May 2015 16:57:20 -0000 1.194 > +++ relay.c 25 May 2015 16:20:16 -0000 > @@ -1649,8 +1649,7 @@ relay_close(struct rsession *con, const > __func__, relay_inflight); > } > } > - if (con->se_in.buf != NULL) > - free(con->se_in.buf); > + free(con->se_in.buf); > > if (con->se_out.bev != NULL) > bufferevent_free(con->se_out.bev); > > > -- > --------------------------------------------------------------------------------------------------------------------- > () ascii ribbon campaign - against html e-mail > /\
your diff is incomplete... well, why just this occurrence? there is others check null before free(3) in same file. and please, be more specific adding more details about your changes: eg.: (I am removing the null check here, because free(3) itself already check against null).
