On Mon, Oct 20, 2014 at 01:22:05PM +0100, Stuart Henderson wrote: > Any comments on the diff in this?
Not sure why you're singling out pppoe(4). Don't other interfaces that use sppp's IPv6CP have the same problem? Are there no others? Generally, I think it would be better to keep IPv6 disabled by default and apply the documentation change you proposed when starting this discussion. > > Index: if_pppoe.c > > =================================================================== > > RCS file: /cvs/src/sys/net/if_pppoe.c,v > > retrieving revision 1.41 > > diff -u -p -w -r1.41 if_pppoe.c > > --- if_pppoe.c 13 Aug 2014 12:03:40 -0000 1.41 > > +++ if_pppoe.c 8 Oct 2014 12:24:07 -0000 > > @@ -245,6 +245,9 @@ pppoe_clone_create(struct if_clone *ifc, > > timeout_set(&sc->sc_timeout, pppoe_timeout, sc); > > > > if_attach(&sc->sc_sppp.pp_if); > > +#ifdef INET6 > > + sc->sc_sppp.pp_if.if_xflags &= ~IFXF_NOINET6; > > +#endif > > if_alloc_sadl(&sc->sc_sppp.pp_if); > > sppp_attach(&sc->sc_sppp.pp_if); > > #if NBPFILTER > 0 > >
