On 29 August 2014 18:01, Damien Miller <d...@mindrot.org> wrote: > What's the benefit of this?
This creates a UDP PCB per connection. Otherwise we always rely on matching the wildcard PCB. > I've never seen an application do this; I doubt that. However, things like NTP or DNS servers usually expect requests from everyone so they don't do it. Now I have actually identified one use case that this diff breaks: multiple senders won't work. Which is kind of annoying. > wouldn't it be better to improve the PCB cache so it caught this case > (which seems the usual way UDP applications behave) instead? > Definitely! Using something like a prefix tree (mickey advocates hash array mapped tries) would eliminate this second lookup and also solve problems with attacking PCB hash with collisions and resizing the hash table. > -d >
