Those are just suggestions... I'm going trough my list so in the future a simple "NO" and I'll stop tracking the patch and back off.
On Mon, 26 May 2014 12:57:10 -0600 Theo de Raadt <dera...@cvs.openbsd.org> wrote: > no no, please stay out of ld.so and subdirectories. > > I'm working on these kinds of issues in there already, and I don't > want any collisions. > > > Index: prebind_path.c > > =================================================================== > > RCS file: /cvs/src/libexec/ld.so/ldconfig/prebind_path.c,v > > retrieving revision 1.2 > > diff -u -p -r1.2 prebind_path.c > > --- prebind_path.c 13 Nov 2013 05:41:43 -0000 1.2 > > +++ prebind_path.c 25 May 2014 08:19:14 -0000 > > @@ -24,10 +24,7 @@ > > void * > > _dl_malloc(size_t need) > > { > > - void *ret = malloc(need); > > - if (ret != NULL) > > - memset(ret, 0, need); > > - return (ret); > > + return calloc(1, need); > > } > > > > void > > >