On Fri, Apr 4, 2014 at 11:42 AM, Philip Guenther <guent...@gmail.com> wrote:
>>> >     /* Do not exit before child to ensure data integrity */
>>> > -   if (zpid > 0)
>>> > +   if (zpid > 0) {
>>> >             waitpid(zpid, &status, 0);
>>> > +           if (WIFEXITED(status) && WEXITSTATUS(status))
>>> > +                   exit_val = 1;
>>> > +   }
>
> Hmm, should that be
>     if (!WIFEXITED(status) || WEXITSTATUS(status))

...so that gzip dying from a signal is also a failure.


Other than that tweak, I like both changes.  ok guenther@

Reply via email to