On Sun, Nov 03, 2013 at 03:06:23PM +0000, Stuart Henderson wrote: > cc1plus: warnings being treated as errors > In file included from > /usr/obj/squid-3.4.0.2/squid-3.4.0.2/src/DiskIO/DiskThreads/aiops.cc:43: > /usr/include/sys/stat.h:199: warning: 'int stat(const char*, stat*)' hides > constructor for 'struct stat' > > I can just get rid of -Werror, but is this important?
Unless struct stat turns out to be a class with a constructor, and the code wants to construct a stat object instead of calling the syscall, it's fine. Well for a value of "fine" between poor-choice-of-name and squid-code-retarded.
