On Fri, Jul 12, 2013 at 08:24:30PM +0200, Maxime Villard wrote:
> Hi,
> as I did for NetBSD, here is a list of 14 potential bugs/errors
> found by my code scanner in OpenBSD:
>
> http://M00nBSD.net/e5ab5f6e59d6a0feb7d1a518acc8233d.html
>
> I do not provide patches.
>
You are right about macppc/stand/boot.mac/fixcoff.c. Only Old-World Macs are
affected where we don't really run anyway...
Here is the diff which fixes the RCS IDs as bonus.
Index: elf32_powerpc_merge.x
===================================================================
RCS file: /cvs/src/sys/arch/macppc/stand/boot.mac/elf32_powerpc_merge.x,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 elf32_powerpc_merge.x
--- elf32_powerpc_merge.x 5 Dec 2006 20:30:26 -0000 1.1
+++ elf32_powerpc_merge.x 12 Jul 2013 19:54:14 -0000
@@ -1,4 +1,4 @@
-/* $OpenBSD: */
+/* $OpenBSD$ */
OUTPUT_ARCH(powerpc)
SECTIONS
{
Index: fixcoff.c
===================================================================
RCS file: /cvs/src/sys/arch/macppc/stand/boot.mac/fixcoff.c,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 fixcoff.c
--- fixcoff.c 5 Dec 2006 20:30:26 -0000 1.1
+++ fixcoff.c 12 Jul 2013 19:54:14 -0000
@@ -1,4 +1,4 @@
-/* $OpenBSD: */
+/* $OpenBSD$ */
/* $NetBSD: fixcoff.c,v 1.10 2006/04/07 02:34:55 gdamore Exp $ */
/*
@@ -143,7 +143,7 @@ main(int argc, char *argv[])
}
if ((fd = open(argv[0], O_RDWR, 0)) == -1)
- err(i, "%s", argv[0]);
+ err(1, "%s", argv[0]);
/*
* Make sure it looks like an xcoff file..
