On Fri, May 31, 2013 at 5:43 PM, Stefan Sperling <s...@openbsd.org> wrote: > Yes. Conversion currently depends on the GNU iconv port. > If iconv existed in base we could use just the UTF-8 source files.
Hmm, I see. In that case, I guess committing converted files makes sense. In your man page diff, you should make use of .Dv and .Ev to identify the defines and environment variables. Instead of setting FD_CLOEXEC with fcntl(), just use O_CLOEXEC when opening. It looks like parse_lang() won't handle locales like "C.UTF-8" because there's no '_'. I think you should be able to implement the %l/%t/%c stuff without needing to call strdup() for each one (e.g., by just doing a one time pass over the locale string up front and noting where the '_' and '.' chars are). Otherwise, you should report strdup() failures as ENOMEM to the catopen() caller, I think.
