On Tue, Jan 22, 2013 at 03:37:32PM +0100, Jan Stary wrote:
> In dhclient.conf.5 at two places,
> text is (unnecessarily IMHO) indented
> in a way mandoc -Tlint complains about.
>
> Jan
>
> /usr/src/sbin/dhclient/dhclient.conf.5:299:6: WARNING: tab in non-literal
> context
> /usr/src/sbin/dhclient/dhclient.conf.5:398:6: WARNING: tab in non-literal
> context
>
hi. actually i'm not convinced about mandoc's warnings for this one - it
does grumble about tabs unneccessarily, i think. check out the man4
pages, for example. there's a rake. maybe ingo wants to comment on that,
but as far as i'm concerned, this text does benefit from the indent, and
mdoc does not make arbitrary tab insertion overly easy. and it's not
wrong (to my mind), so i don;t see that it needs removing.
having said that, the macro stuff in there is awful. it's a leftover
from having to appease the groff monster, so we could simplify it. for
example i suspect the first block of text could be changed to exactly:
.D1 Ic lease Brq Ar lease-declaration Op Ar ...
still, i need to check with ken if the resulting loss of whitespace
would be acceptable.
so, i'm not taking it out just now. but i might get round to cleaning up
the macros in this file.
jmc
>
> Index: dhclient.conf.5
> ===================================================================
> RCS file: /cvs/src/sbin/dhclient/dhclient.conf.5,v
> retrieving revision 1.26
> diff -u -p -r1.26 dhclient.conf.5
> --- dhclient.conf.5 27 Nov 2012 15:51:48 -0000 1.26
> +++ dhclient.conf.5 22 Jan 2013 14:34:09 -0000
> @@ -296,7 +296,7 @@ the behaviour will be unpredictable.
> The lease declaration:
> .Pp
> .Xo
> -.Ic \ \& lease No { Ar lease-declaration
> +.Ic lease No { Ar lease-declaration
> .Oo Ar ... lease-declaration Oc }
> .Xc
> .Pp
> @@ -395,7 +395,7 @@ DHCP client.
> .Pp
> Dates are specified as follows:
> .Pp
> -.Ar \ \&<weekday>
> +.Ar <weekday>
> .Sm off
> .Ar <year> No / Ar <month> No / Ar <day>
> .Ar <hour> : <minute> : <second>
