On Tue, Sep 04, 2012 at 12:53, Ted Unangst wrote:
> On Tue, Sep 04, 2012 at 09:57, Kenneth R Westerback wrote:
> 
>>
>> The problem seems to be rooted in a desire to printf() the dosname
>> in a debug statement. Otherwise the dos file names are not treated
>> as strings anywhere.
>>
>> An alternate solution, that restores the symmetry between unix2dosfn()
>> and dos2unixfn(), is to use %.11s to print the dos file name in that
>> debug chunk, and otherwise consistantly treat the various dos file
>> names as 11-byte arrays.
>>
>> Eliminiating one magic number (12) would seem a good thing. :-)
>>
>> Comments about the non-stringiness of these vars might be good too.
> 
> I was looking at this too.  There's also de_Name in denode.h and a
> printf of that as well.  Change that too and ok.

It's in a struct, so maybe add a pad char afterwards, but I think we
can let the compiler work that out.  It's not a physical struct.

Reply via email to